Skip to content

Fix throughput-spike OTA timeout build by defining work item before use #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MacNite merged 1 commit into from
Sep 7, 2026
Merged

Fix throughput-spike OTA timeout build by defining work item before use #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions firmware-nrf54lm20a/src/ota.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ static void record_errno(int rc)
}

static void arm_timeout_handler(struct k_work *work);
static void reboot_handler(struct k_work *work);
static void stall_timeout_handler(struct k_work *work);
K_WORK_DELAYABLE_DEFINE(arm_timeout_work, arm_timeout_handler);
K_WORK_DELAYABLE_DEFINE(reboot_work, reboot_handler);
K_WORK_DELAYABLE_DEFINE(stall_timeout_work, stall_timeout_handler);

#if ENABLE_THROUGHPUT_SPIKE
void ota_release_arm_timeout(void)
{
Expand All @@ -60,12 +66,6 @@ void ota_release_arm_timeout(void)
}
#endif

static void reboot_handler(struct k_work *work);
static void stall_timeout_handler(struct k_work *work);
K_WORK_DELAYABLE_DEFINE(arm_timeout_work, arm_timeout_handler);
K_WORK_DELAYABLE_DEFINE(reboot_work, reboot_handler);
K_WORK_DELAYABLE_DEFINE(stall_timeout_work, stall_timeout_handler);

static ssize_t ctrl_write(struct bt_conn *, const struct bt_gatt_attr *,
const void *, uint16_t, uint16_t, uint8_t);
static ssize_t data_write(struct bt_conn *, const struct bt_gatt_attr *,
Expand Down
Loading