Fix ground Z offset for MapAndreas/ColAndreas move modes#1
Open
Doomset wants to merge 1 commit into
Open
Conversation
Original ziggi FCNPC adds 1.0m to sampled ground Z in UpdateHeightPos; the open.mp port applied mesh Z directly, causing NPCs to sink while moving. Apply the same ped origin offset in onTick after findGroundZ. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kGroundPedZOffset(1.0 m) when applying MapAndreas/ColAndreas ground Z inFCNPCComponent::onTick.CPlayerData::UpdateHeightPos, which setsfNewZ = groundZ + 1.0ffor both move modes.Problem
With
FCNPC_MOVE_MODE_COLANDREAS(and MapAndreas), NPCs visually sink into the ground while moving: ColAndreas returns mesh Z, but the ped origin should sit ~1 m above that surface (same as players). The open.mp port wrote mesh Z directly vianpc->setPosition.Observed on open.mp + ColAndreas: player
Z - CA_FindZ ? +1.0, NPC? +0.1before fix; after fix both align.Test plan
FCNPC_MOVE_MODE_COLANDREAS.FCNPC_MOVE_MODE_MAPANDREASif MapAndreas plugin is loaded.FCNPC_MOVE_MODE_NONEunchanged.