feat(infrast): Rotation 进驻总览预设 UI 与内联 preset 参数 - #98
Open
xjbsteven wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Hey - 我在这里留下了一些高层面的反馈:
- 与接收相关的开关现在在
defaultPreferenceForm和stationPresetPreferenceForm中被重复定义,而且排序也不一致,这会让视图更难维护;可以考虑抽取一个共享的子视图或辅助方法,在不同模式下保持这组开关的集合和顺序一致。 - 现在
DronesPayload已经是 Encodable 并接入了InfrastTaskAPIParams,StationPresetDrones.apiPayload字典似乎已经不再使用;可以考虑删除apiPayload,或者让所有序列化都通过同一条代码路径,以避免逻辑分叉。
给 AI 代理的提示词
Please address the comments from this code review:
## Overall Comments
- 与接收相关的开关现在在 `defaultPreferenceForm` 和 `stationPresetPreferenceForm` 中被重复定义,而且排序也不一致,这会让视图更难维护;可以考虑抽取一个共享的子视图或辅助方法,在不同模式下保持这组开关的集合和顺序一致。
- 现在 `DronesPayload` 已经是 Encodable 并接入了 `InfrastTaskAPIParams`,`StationPresetDrones.apiPayload` 字典似乎已经不再使用;可以考虑删除 `apiPayload`,或者让所有序列化都通过同一条代码路径,以避免逻辑分叉。帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进今后的代码审查。
Original comment in English
Hey - I've left some high level feedback:
- The reception-related toggles are now duplicated and ordered differently between
defaultPreferenceFormandstationPresetPreferenceForm, which makes the view harder to maintain; consider extracting a shared subview or helper to keep the set and ordering of toggles consistent across modes. - The
StationPresetDrones.apiPayloaddictionary appears unused now thatDronesPayloadis Encodable and wired intoInfrastTaskAPIParams; consider either removingapiPayloador routing all serialization through a single code path to avoid divergence.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The reception-related toggles are now duplicated and ordered differently between `defaultPreferenceForm` and `stationPresetPreferenceForm`, which makes the view harder to maintain; consider extracting a shared subview or helper to keep the set and ordering of toggles consistent across modes.
- The `StationPresetDrones.apiPayload` dictionary appears unused now that `DronesPayload` is Encodable and wired into `InfrastTaskAPIParams`; consider either removing `apiPayload` or routing all serialization through a single code path to avoid divergence.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
xjbsteven
force-pushed
the
feat/infrast-auto-advance-plan-index
branch
from
June 30, 2026 03:03
711daf6 to
7b11ba5
Compare
- Custom 模式 auto_advance_plan_index:任务链完成后自动切下一班次 - Rotation station_preset:布局 Stepper、设施勾选、无人机、会客室开关 - 内联 preset/drones API 序列化;默认布局 423,UserDefaults 记忆上次布局 Co-authored-by: Cursor <cursoragent@cursor.com>
xjbsteven
force-pushed
the
feat/infrast-auto-advance-plan-index
branch
from
June 30, 2026 03:09
7b11ba5 to
6e48c42
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
station_preset:布局 Stepper、设施勾选、无人机、会客室开关、干员休整preset/dronesAPI 序列化(对接主仓 CoreInfrastTask)auto_advance_plan_index仅 Custom 模式主仓 PR:MaaAssistantArknights#17164(本 PR 须先合并,再由主仓 bump 子模块指针)
Test plan
Made with Cursor
Summary by Sourcery
在核心 InfrastTask API 参数中,新增一种轮换样式(rotation style),该样式使用基础概览预设以及线路(wire)基础设施配置。
新功能:
增强:
Original summary in English
Summary by Sourcery
Add a new rotation style that uses base overview presets and wire infrast configuration to the core InfrastTask API parameters.
New Features:
Enhancements: