feat: implement NSLocalizedString - #24
Open
RieLCho wants to merge 1 commit into
Open
Conversation
Collaborator
|
Sorry for the delay. In SwiftUI, most Views are automatically using |
Collaborator
|
@RieLCho Hi, I have added preliminary support for i18n in 35e1c8b. Most of the localizable strings are tracked by the string catalog. To accomplish the remaining translation, please consider the following steps: If you have Xcode 15+:
If you prefer to use a text editor:
{
"%@ HasReturned" : { <-- source key
"localizations" : {
"ko" : {
"stringUnit" : {
"state" : "translated",
"value" : "%@가 돌아왔습니다" <-- translation
}
}
}
}
}Please IGNORE the entries with After the translation, please submit another pull request, because this PR has too many conflicts to merge. Thanks! |
Contributor
Author
|
Hi, @hguandl
|
hguandl
force-pushed
the
master
branch
5 times, most recently
from
February 7, 2025 02:43
d93044c to
7239976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


So I tried to implement NSLocalizedString, which I issued earlier (MaaAssistantArknights/MaaAssistantArknights#8770)
but I think I failed to collect all of the hardcoded chinese.