Let az and za arrays have an arbitrary number of axes - #1
Open
johnsmorgan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a modest change to mwa_pb. At present, the zenith angle and azimuth arrays must have two dimensions (i.e. assuming that you want to make a primary beam image). Often you just want the primary beam for a list of locations. The following generalise the code so that an arbitrary number of dimensions can be used. I've located one function that will fail with this change (plotVisResponse) and made sure that it fails with a proper error.
I've tested this code for some basic use cases without any issues.
Before merging, can someone please double-check my first change to primary_beam.py (the swapaxes on) I think it's equivalent to the two cases it replaces, but it would be good for someone to double-check.