add --elevation-limit CLI flag to di-calibrate and srclist-by-beam - #83
Merged
Conversation
Make the elevation cutoff in veto_sources configurable rather than fixed at compile time. - Rename constant ELEVATION_LIMIT -> DEFAULT_ELEVATION_LIMIT in constants.rs - Add `min_elevation_deg: f64` parameter to veto_sources(); all callers updated (SkyModelWithVetoArgs, by_beam, vis-simulate passes the default) - Add --elevation-limit <DEG> flag to SkyModelWithVetoArgs (used by di-calibrate) and SrclistByBeamArgs (srclist-by-beam); defaults to DEFAULT_ELEVATION_LIMIT (0°) when not supplied - Add test `elevation_limit_rejects_sources` verifying that a below-horizon source is always rejected, a zenith source survives reasonable limits, and an impossible limit (>90°) empties the source list
gsleap
self-requested a review
May 15, 2026 04:23
gsleap
marked this pull request as draft
May 15, 2026 04:25
gsleap
marked this pull request as ready for review
May 15, 2026 04:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the elevation cutoff in veto_sources configurable rather than fixed at compile time.
min_elevation_deg: f64parameter to veto_sources(); all callers updated (SkyModelWithVetoArgs, by_beam, vis-simulate passes the default)elevation_limit_rejects_sourcesverifying that a below-horizon source is always rejected, a zenith source survives reasonable limits, and an impossible limit (>90°) empties the source list