dashboard: KVM/Terminal use the browser's host (location.hostname), not a guessed IP

The box has two DHCP addresses on enp4s0 (.24 primary, .40 secondary); guessing the IP server-side picked the wrong one. Now the frontend builds KVM/terminal URLs from location.hostname, and status reports the Host you connected with.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: MTSistemi

apps/dashboard/skillfish-dashboardd

@@ -191,7 +191,10 @@ def sysinfo():
             return ""
     info = {}
     info["host"] = sh("hostname")
-    info["ip"] = sh("hostname -I").split()[0] if sh("hostname -I") else ""
+    # primary LAN IP = source address of the default route (not just the first of
+    # `hostname -I`, which can be a secondary/stale or docker/lxc address).
+    info["ip"] = (sh(r"ip -4 route get 1.1.1.1 2>/dev/null | sed -n 's/.*src \([0-9.]*\).*/\1/p'")
+                  or (sh("hostname -I").split()[0] if sh("hostname -I") else ""))
     info["kernel"] = sh("uname -r")
     try:
         with open("/proc/uptime") as f:
@@ -413,9 +416,9 @@ def kvm_start():
                           "--web", "/usr/share/novnc", str(KVM_PORT), "localhost:5901"],
            kill_pat="websockify --cert")
     time.sleep(0.8)
-    ip = sysinfo().get("ip", "")
-    return {"ok": True, "url": "https://%s:%d/vnc.html?autoconnect=1&resize=scale&password=%s"
-            % (ip, KVM_PORT, VNC_PASS), "password": VNC_PASS}
+    # the frontend builds the URL from the host the browser is already using, so we
+    # never advertise a wrong/secondary IP — just hand back the port + password.
+    return {"ok": True, "port": KVM_PORT, "password": VNC_PASS}
 
 
 def kvm_stop():
@@ -435,8 +438,7 @@ def terminal_start():
                     "-c", "skillfish:" + TTYD_TOKEN, "-W", "-t", "fontSize=14", "--", "su", "-", u],
            kill_pat="ttyd --ssl")
     time.sleep(0.8)
-    ip = sysinfo().get("ip", "")
-    return {"ok": True, "url": "https://%s:%d" % (ip, TTYD_PORT), "user": "skillfish", "token": TTYD_TOKEN}
+    return {"ok": True, "port": TTYD_PORT, "user": "skillfish", "token": TTYD_TOKEN}
 
 
 def terminal_stop():
@@ -518,7 +520,9 @@ class Handler(BaseHTTPRequestHandler):
         if path == "/api/status":
             if not self._user():
                 return self._json(401, {"error": "auth"})
-            return self._json(200, sysinfo())
+            s = sysinfo()
+            s["you"] = (self.headers.get("Host", "") or "").split(":")[0]  # host you actually reached us on
+            return self._json(200, s)
         if path == "/api/telemetry":
             if not self._guard("telemetry"):
                 return

apps/dashboard/web/app.js

@@ -96,7 +96,7 @@ const RENDER = {
         const s = await (await api("/api/status")).json();
         const row = (a, b) => `<div class="r"><span>${a}</span><span>${b || "–"}</span></div>`;
         $("#srows", card).innerHTML =
-          row("Host", s.host) + row("IP", s.ip) + row("Kernel", s.kernel) +
+          row("Sei connesso a", s.you) + row("Host", s.host) + row("IP (rotta)", s.ip) + row("Kernel", s.kernel) +
           row("Uptime", s.uptime) + row("CU attive", s.cu) +
           row("RAM", s.ram_used_mb ? `${s.ram_used_mb} / ${s.ram_total_mb} MB` : "") +
           row("Disco /", s.disk_used ? `${s.disk_used} / ${s.disk_total} (${s.disk_pct})` : "") +
@@ -177,15 +177,25 @@ const RENDER = {
       '<div class="stub" id="kvmi" style="margin-top:8px">Schermo, tastiera e mouse della scheda nel browser.</div>';
     $("#kvmgo", card).onclick = async () => {
       const j = await action("/api/kvm/start", {}, "Desktop pronto");
-      if (j && j.url) { window.open(j.url, "_blank"); $("#kvmi", card).innerHTML = "Aperto in nuova scheda. Password VNC: <b>" + j.password + "</b>"; }
+      if (j && j.port) {
+        const url = `https://${location.hostname}:${j.port}/vnc.html?autoconnect=1&resize=scale&password=${encodeURIComponent(j.password)}`;
+        window.open(url, "_blank");
+        $("#kvmi", card).innerHTML = 'Aperto in nuova scheda. Se appare un avviso certificato, accettalo (porta ' + j.port + ').';
+      }
     };
   },
   terminal(card) {
     card.innerHTML = '<h3>⌨️ Terminale</h3><div class="brow"><button class="dbtn" id="tgo">▶ Apri terminale</button></div>' +
       '<div class="stub" id="ti" style="margin-top:8px">Shell della scheda nel browser.</div>';
     $("#tgo", card).onclick = async () => {
       const j = await action("/api/terminal/start", {}, "Terminale pronto");
-      if (j && j.url) { window.open(j.url, "_blank"); $("#ti", card).innerHTML = "Aperto. Login: utente <b>" + j.user + "</b> · token <b>" + j.token + "</b>"; }
+      if (j && j.port) {
+        const url = `https://${location.hostname}:${j.port}`;
+        window.open(url, "_blank");
+        $("#ti", card).innerHTML = 'Aperto su <b>' + location.hostname + ':' + j.port + '</b>.<br>' +
+          'Accetta l\'eventuale avviso certificato, poi nel login inserisci:<br>' +
+          'utente <b>' + j.user + '</b> · password <b style="user-select:all">' + j.token + '</b>';
+      }
     };
   },
   _stub(card, mod) {