chore: scrub real personal data from test fixtures and docs#271
Merged
Conversation
Replaces real names/phone numbers/a precise GPS coordinate that leaked into test fixtures and doc comments during dogfooding with fictional equivalents, ahead of open-sourcing the repo. Closes #270
There was a problem hiding this comment.
Pull request overview
Scrubs leaked real personal data (names, phone numbers, and a precise GPS coordinate) from test fixtures and documentation/comment examples to make the repository safe to open-source, without changing runtime behavior.
Changes:
- Replaces real person-name fixtures/examples with fictional equivalents across tests and inline docs/comments.
- Replaces real phone-number fixtures/examples with NANP fictional numbers, updating corresponding assertions.
- Replaces a precise GPS coordinate in the photo-exif connector test with a coarse, non-identifying coordinate.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/db.js |
Updates doc comments/examples for phone normalization, name variants, relation hint staging, and handle annotation. |
src/contacts.js |
Updates preferredDisplayName doc comment name examples. |
public/chat.js |
Updates inline comment example for display_text handle annotation. |
scripts/backfill-phone-aliases.js |
Updates header comment phone-number examples to fictional equivalents. |
scripts/backfill-display-names.js |
Updates header comment name example to fictional equivalent. |
test/db.test.mjs |
Updates fixtures/assertions for display text annotation, display-name reduction, and phone normalization tests. |
test/server.test.mjs |
Updates propose-entity phone-alias normalization test inputs to fictional numbers. |
test/contacts.test.mjs |
Updates nameVariants fixtures/assertions to the fictional names. |
connectors/photo-exif/test.mjs |
Updates Takeout sidecar fixtures/assertions for pictured names and GPS coordinate; updates album-layout folder-name hint fixture. |
README.md |
Updates user-facing examples for phone canonicalization and display-name behavior. |
docs/03-ob2-design.md |
Updates design doc example relationship text to fictional name. |
.claude/rules/data-model.md |
Updates data-model documentation examples for name/phone/display_text to fictional values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+69
to
+71
| Phone numbers are matched by a canonical key (#129): US/Canada numbers written with a `+1` country code (`+1 (415) 555-0148`) resolve to the same contact as the bare 10-digit form (`(415) 555-0148`) — punctuation, spacing, and the `+1` all normalize away. Contacts imported before this change are re-aliased under the canonical key by `npm run backfill:phones` (additive and idempotent — back up `life-context.db` first). | ||
|
|
||
| A contact's **display name defaults to first + last** (#156): a card with a middle name (`Amy Margaret Schneider`) is stored and shown as `Amy Schneider`, while the full name is kept as a searchable alias — so search/timeline read cleanly without losing resolution by the full name. Contacts imported before this change are shortened by `npm run backfill:display-names` (idempotent; back up `life-context.db` first). | ||
| A contact's **display name defaults to first + last** (#156): a card with a middle name (`Amy Margaret Fenwick`) is stored and shown as `Amy Fenwick`, while the full name is kept as a searchable alias — so search/timeline read cleanly without losing resolution by the full name. Contacts imported before this change are shortened by `npm run backfill:display-names` (idempotent; back up `life-context.db` first). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #270
Summary
Changes
Amy Margaret Schneider/Amy Schneider/Adam Schneider→Amy Margaret Fenwick/Amy Fenwick/Adam FenwickApril Delugach Paine/Matt Paine→April Marsh Sorrel/Matt Sorrel2564680130(all formats) →4155550148; phone+12406725399→+1202555017138.8981222,-77.0334917→39.0,-76.0Verification
npm test: 186/186 passnpm run check:boundary: OKconnectors/photo-exifsuite: 20/21 pass (1 pre-existing unrelated Windows flake, reproduced identically on unmodified main)Test plan