feat(tooling): require a Skills & scripts section in review skills#265
Merged
Conversation
…d pre-doc-review Both review skills now always emit a change-grounded recommendation (new skill / update existing / save script / none) so reusable procedures get codified instead of re-derived. Refs #257. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YKt6y3Rk498eBqneiMKHpM
There was a problem hiding this comment.
Pull request overview
Updates the repository’s built-in review skills (/pre-pr-review and /pre-doc-review) to always include a required, change-grounded Skills & scripts section, ensuring repeatable procedures and ad-hoc scripts are explicitly considered for codification (per #257).
Changes:
- Add Step 3.5 — Skills & scripts (required) to
/pre-pr-review, positioned between the verdict and the smoke-test gate. - Add a parallel Step 3.5 — Skills & scripts (required) to
/pre-doc-review, positioned between the verdict and Clear-the-gate. - Make the section explicitly advisory (recommendations only; no auto-creation).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .claude/commands/pre-pr-review.md | Inserts a mandatory “Skills & scripts” checkpoint into the code pre-PR review flow. |
| .claude/commands/pre-doc-review.md | Inserts the same mandatory “Skills & scripts” checkpoint into the doc pre-PR review flow (doc-focused wording). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257
Summary
Both
/pre-pr-reviewand/pre-doc-reviewnow always emit a required, change-grounded Skills & scripts section (new skill / update existing / save script / none), so reusable procedures get codified in the repo instead of re-derived from a transcript each time. Advisory only — it surfaces the candidate; it never auto-creates anything.Changes
.claude/commands/pre-pr-review.md— new Step 3.5 — Skills & scripts (required) between the verdict and the smoke-test gate..claude/commands/pre-doc-review.md— parallel Step 3.5 between the verdict and Clear-the-gate (doc-flavored wording).Verification
src/**, server, schema, or auth touched — server runs byte-identical, so no smoke test applies.#257is the governing issue./pre-pr-reviewrun emitted the new Skills & scripts section (verdict: none warranted).Test plan
/pre-pr-reviewand/pre-doc-reviewruns each emit the Skills & scripts section, grounded in the change under review.