Chirp distance and mass joint distribution#304
Open
aggar104 wants to merge 13 commits into
Open
Conversation
deepchatterjeeligo
requested changes
May 28, 2026
deepchatterjeeligo
left a comment
deepchatterjeeligo
left a comment
Contributor
There was a problem hiding this comment.
Hi @aggar104 thanks for starting this. I think the overall idea is correct. I was hoping for this to be a little simpler and be Uniform in chirp distance. Could you also share a plot which should what the samples look like? And also please add some nice unittests.
| def __init__( | ||
| self, | ||
| chirp_mass: torch.distributions.Distribution, | ||
| chirp_distance: torch.distributions.Distribution, |
Contributor
There was a problem hiding this comment.
Why do we need a chirp_distance as an input distribution?
| ): | ||
|
|
||
| chirp_mass = self.chirp_mass.sample(N) | ||
| chirp_distance = self.chirp_distance.sample(N) |
Contributor
There was a problem hiding this comment.
So I was hoping that we call this distribution UniformChirpDistance meaning the result chirp distance distribution is uniform.
Contributor
|
@aggar104 gentle bump on this. |
added 3 commits
June 22, 2026 21:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jointly sample chirp mass and luminosity distance according to the chirp distance scaling.