Regression & Multitask#452
Open
benedict-armstrong wants to merge 7 commits into
Open
Conversation
added 7 commits
May 31, 2026 14:25
…kground. Updated datasets, waveform generators and models to accept/return parameters as part of the batch
…lasses. Updated Autoencoder and Supervised models to inherit from AframeClassification. Added new SupervisedMultiTaskAframe and SupervisedRegressionAframe classes for multi-task and regression tasks.
- Introduced RegressionArchitecture and MultiTaskArchitecture classes in regression.py. - Added RegressionTimeDomainResNet and MultiTaskTimeDomainResNet classes for regression tasks. - Created multitask.yaml and regression.yaml for multi-task and regression training configurations. - Enhanced BaseAframeDataset to support parameter transformations. - Implemented ChirpMass and MassRatio transforms for parameter calculations. - Updated AframeWandbLogger for improved logging capabilities.
benedict-armstrong
changed the title
Contributor
There was a problem hiding this comment.
Again, I really like breaking up the AframeBase into something simpler. Once you are done with #451, let's rebase this and get this into the regression-datamodules branch
Contributor
|
Can this be made against the regression-datamodules branch please? |
|
Same pull request made to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Work in Progress
This PR builds on top of #451 (most of the changes are from there) and adds two training tasks:
projects/train/train/model/regression.py; Designed to be used withwaveform_prob=1.0projects/train/train/model/multitask.py; Both regression and classification at the same time. So have a regression and a classification head on the same model.The
AframeBasemodel base class inprojects/train/train/model/base.pyis refactored to be a general base class for all task types.projects/train/train/model/{classification|regression|multitask}.pyinherit fromAframeBaseand implement specifics for each task.The two configs in
projects/train/configs/regression/show how to setup the two respective models. Before merging I would remove/refactor these similar to the other training configs.