Adjustable legacy builder#142
Conversation
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
There was a problem hiding this comment.
Pull request overview
Adds an AdjustableLegacyBuilder trajectory builder that preserves LegacyBuilder’s default AEIC v2 behavior while allowing per-mission adjustments (fixed or callable) for key geometry and fuel-policy assumptions.
Changes:
- Introduces
AdjustableLegacyBuilder/AdjustableLegacyContextwith adjustment hooks for altitudes, descent planning, and reserve/divert/hold policy. - Adds a dedicated test suite covering default-equivalence to legacy behavior, fixed adjustments, callable adjustments, clamping, and validation errors.
- Updates builder exports and documentation; also hardens context cleanup in
Builder.flyand fixes a legacy error-message typo.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/AEIC/trajectories/builders/adjustable_legacy.py |
New adjustable legacy builder/context implementation with adjustment plumbing and legacy-equivalent integration logic. |
tests/test_adjustable_legacy_builder.py |
New tests validating equivalence, adjustment behavior, clamping, and error handling. |
src/AEIC/trajectories/builders/base.py |
Makes context cleanup resilient to context-construction failures. |
src/AEIC/trajectories/builders/legacy.py |
Fixes a spacing typo in an error message. |
src/AEIC/trajectories/builders/__init__.py |
Re-exports AdjustableLegacyBuilder. |
docs/src/trajectories/trajectory_builders.md |
Documents the new builder, its adjustment arguments, and validation/clamping rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: GPT-5.5 <openai-codex-gpt-5.5@pi.local> Pi-Model: openai-codex/gpt-5.5
lrobion
left a comment
There was a problem hiding this comment.
Added flexibility is great and covers a lot more stuff than altitude thanks! I left a few code related comments for structure etc... I think functionality is great!
|
@lrobion I've merged this, so you can get at it by installing from the main branch. It will end up in the v1.0 release, which might even happen next week or the week after, depending... |
Adds a new trajectory builder type,
AdjustableLegacyBuilder. This defaults to the same behavior as the main legacy builder intended to replicate MATLAB AEIC v2 behavior, but it exposes a number of hooks to adjust various aspects of the trajectory simulation.