Lowest common ancestor - #496

Open

Safi222 wants to merge 222 commits into

mainfrom

lowest_common_ancestor

Commits on Dec 24, 2024

Commits on Dec 29, 2024

Merge branch 'main' of https://github.com/MIT-Emerging-Talent/ET6-practice-code-review
reunicorn1
committed
81f26fe

Commits on Dec 30, 2024

Adding the learning goals
Goutbi
committed
3da9d0a
Adding the Constraints
Goutbi
committed
e4f3e80
Adding the empty python file
Goutbi
committed
5e312da
Adding the Python file
Goutbi
committed
f09f7dc
adding empty python files
Goutbi
committed
43918ea
created the file for the arithmetic sequence test
Mayar-Agab
committed
1b290f0
I added the test file test_even_number_count.py
Mayar-Agab
committed
75747e4
Added the anagrams problem with its test file
reunicorn1
committed
dcab675
Merge pull request #10 from MIT-Emerging-Talent/learning-goals
reunicorn1
authored
a92c007
adding robot.py file as a problem with its corresponding test
reunicorn1
committed
4bddf02
Quadratic Sequence File
Omnia-Agabani
committed
509a789
Create harmonic_sequence file
Omnia-Agabani
committed
b7c55a7
Merge pull request #11 from MIT-Emerging-Talent/constraints
Omnia-Agabani
authored
4807364
Harmonic Sequence code with test
Omnia-Agabani
committed
095a353
Add more tests and assert error
Omnia-Agabani
committed
d45fbfa
Fix 1 test result
Omnia-Agabani
committed
f2a9ca4
Add more comments
Omnia-Agabani
committed
ebe0c80
Add more details in the documment
Omnia-Agabani
committed
f71e319
Quadratic Sequence code
Omnia-Agabani
committed
1ee1c5d

Commits on Dec 31, 2024

initial commit
sajaabusafia
committed
979058f
Merge branch 'main' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into word-count-txt-file
sajaabusafia
committed
faa9342
Merge branch 'MIT-Emerging-Talent:main' into word-count-txt-file
sajaabusafia
authored
bcc0ffd
modifications for cl
sajaabusafia
committed
bb06938
Merge branch 'word-count-txt-file' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into word-count-txt-file
sajaabusafia
committed
9e33bd1
Harmonic Sequence code
Omnia-Agabani
committed
e8d4035
Edit the document
Omnia-Agabani
committed
d722bb5
edit communication file
Omnia-Agabani
committed
78d0453
Change document
Omnia-Agabani
committed
b5c563a
fixed checks
Omnia-Agabani
committed
82e4751
update the checks
Omnia-Agabani
committed
ba57371
Delete files error
Omnia-Agabani
committed
6e5731e
Merge branches 'main' and 'word-count-txt-file' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into word-count-txt-file
sajaabusafia
committed
e4adf78
Added the test file and the python file for even_number_count
Mayar-Agab
committed
5d229b0
Delete unnessessory files
Omnia-Agabani
committed
ae56a11
Delete unnessessory files
Omnia-Agabani
committed
9465177
Resolved some errors
Mayar-Agab
committed
05ce776
Updating the document of the test
Omnia-Agabani
committed
85fa602
edits
sajaabusafia
committed
06a8855
edits for cl
sajaabusafia
committed
7a11a1c
edits
sajaabusafia
committed
b639bd1
for E402 Module level import not at top of file
sajaabusafia
committed
6fc464d
final commit
sajaabusafia
committed
ea985a1
modified files for cl
sajaabusafia
committed
49bc671
adding the code without the tests
Goutbi
committed
e283b78
final commit
sajaabusafia
committed
f6bb3af
made changes on tests
Mayar-Agab
committed
8014440
Added Empty File
ayhm01
committed
da575ec
Added defensive cases
Mayar-Agab
committed
2bc4f49

Commits on Jan 1, 2025

unittest added
Goutbi
committed
01ceeee
added unittests and comments
Goutbi
committed
88ec718
Merge branch 'MIT-Emerging-Talent:main' into Fuel-Gauge
Goutbi
authored
4639732
Merge pull request #39 from MIT-Emerging-Talent/Fuel-Gauge
Goutbi
authored
bb20e8a
added edge case
Mayar-Agab
committed
c75eb4a
Merge branch 'main' of github.com:MIT-Emerging-Talent/ET6-foundations-group-27 into ayham/substitution_cipher
ayhm01
committed
9d534a4
Merge branch 'MIT-Emerging-Talent:main' into arithmetic_sequence
Mayar-Agab
authored
d45dd4b
added substitution cipher
ayhm01
committed
81a399b
FooBar code
RafaaAli
committed
9ab033b
Extre changed and CI checks
Mayar-Agab
committed
5d5e16f
changed documentation
Mayar-Agab
committed
6d77720
Merge pull request #41 from MIT-Emerging-Talent/arithmetic_sequence
Mayar-Agab
authored
a4427b0
CI Checks
Mayar-Agab
committed
185b279
Added unit tests for substitution cipher
ayhm01
committed
a7aed16
Merge branch 'MIT-Emerging-Talent:main' into even_number_count
Mayar-Agab
authored
97fe595
added
Mayar-Agab
committed
5bd9e00
extended example
Mayar-Agab
committed
b75c05a
Merge pull request #44 from MIT-Emerging-Talent/arithmetic_sequence
Safi222
authored
88d5ce9

Commits on Jan 2, 2025

problem setup
Safi222
committed
37474b2
Lowest Common Ancestor problem Setup
Safi222
committed
09d0525
modified code and added doctests
Goutbi
committed
b86f066
Merge branch 'Fuel-Gauge' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into Fuel-Gauge
Goutbi
committed
6ed6091
modified code and added doctests
Goutbi
committed
7729789
Merge branch 'Fuel-Gauge' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into Fuel-Gauge
Goutbi
committed
f7b3359
Merge branch 'main' into Fuel-Gauge
Goutbi
authored
4abd3c1
Merge pull request #46 from MIT-Emerging-Talent/Fuel-Gauge
Goutbi
authored
e2463be
modified the code and added doctests
Goutbi
committed
88712dd
pulling the main Merge branch 'Fuel-Gauge' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into Fuel-Gauge
Goutbi
committed
d0cbd01
modified the code
Goutbi
committed
2fb77a0
resolving python formatting -1
Goutbi
committed
60aafa6
fixing pyformatting -2
Goutbi
committed
6f5f69e
tests have been added
RafaaAli
committed
f27bfb7
README.md: adding the edits of the readme file
reunicorn1
committed
e9a079e
Adding the linting fixes
reunicorn1
committed
6775cf1
docstring has been added
RafaaAli
committed
bb6b72a
Fixing linting errors in the python file that got to be involved within the branch of READNE
reunicorn1
committed
e0d51ae
Solving is_anagram problem and adding the corresponding test files
reunicorn1
committed
a5cbc04
reiterate to fix ruff linter errors
reunicorn1
committed
985bf6f
reiterate to fix ls_linting by removing cSpell additions
reunicorn1
committed
451c6bf
fizing ls_linting error by removing the .vscode file from the solutions dir
reunicorn1
committed
332e5b4
adding 7 test cases and the function implementation
Safi222
committed
b64994b
setup for Roman to integer problem with test base case
Safi222
committed
fc913ec

Commits on Jan 3, 2025

Merge pull request #47 from MIT-Emerging-Talent/Fuel-Gauge
reunicorn1
authored
24df055
Fixing ruff linting on existing py files
reunicorn1
committed
3e7f9dd
Merge pull request #43 from MIT-Emerging-Talent/even_number_count
reunicorn1
authored
fc460ef
Merge branch 'main' into README.md
reunicorn1
authored
7647bee
Merge branch 'main' into anagrams
reunicorn1
committed
900b073
fixing ruff linter of fuel_gauge.py file
reunicorn1
committed
d331cb6
initial commit
sajaabusafia
committed
1898784
adding more tests and implementing Roman to integer function
Safi222
committed
71ef956
fixing issues
Safi222
committed
fd2a816
Writing the base code for the robot problem
reunicorn1
committed
4b33517
fixing issues
Safi222
committed
8818d31

Commits on Jan 4, 2025

fixing more issues
Safi222
committed
358fac1
Adding the armstrong checker
Goutbi
committed
ebc09b7
Writing test cases for the function robot and fixing bugs
reunicorn1
committed
41a88f5
fixing ruff linting errors
reunicorn1
committed
647a4ea
adding comments to describe the code functions
Goutbi
committed
55746c1
Merging Main repo updates to repo of group 27
reunicorn1
authored
1629b0b
Merge pull request #57 from MIT-Emerging-Talent/Armstrong_Number
Mayar-Agab
authored
cc61420
missed one docstring
sajaabusafia
committed
e1add43
Merge branch 'main' into quadratic_sequence
reunicorn1
committed
7d7fe51
fixing Ruff linter
reunicorn1
committed
8261b38
edits for docstring
sajaabusafia
committed
b2729d4
Merge branch 'main' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into copy-content-from-txt-file-to-another
sajaabusafia
committed
3b59aa4
edits for docstring
sajaabusafia
committed
82db181
Merge branch 'main' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into word-count-txt-file
sajaabusafia
committed
382655f
added one docstring
sajaabusafia
committed
19c32e9
Revert "Merge branch 'main' of github.com:MIT-Emerging-Talent/ET6-foundations-group-27 into ayham/substitution_cipher"
ayhm01
committed
3cc9d24
docstring modification
sajaabusafia
committed
0d6e7bc
docstring modifications
sajaabusafia
committed
9c79077
Merge branch 'main' of github.com:MIT-Emerging-Talent/ET6-foundations-group-27 into ayham/substitution_cipher
ayhm01
committed
43acb86
adding assertions
Safi222
committed
2423cae
delete dublicated file
sajaabusafia
committed
24a781f
adding my code
Mohamedmxz
committed
e48ef70
testing assertions
Safi222
committed
1198958
adding the code files
Mohamedmxz
committed
8d16abd
fixing importing issues
RafaaAli
committed
62a781a
fixing more issues
RafaaAli
committed
32be9d9
fixing issues
RafaaAli
committed
1927605

Commits on Jan 5, 2025

adding test module
Mohamedmxz
committed
aecfc5a
adding a new test
Mohamedmxz
committed
e3478d3
Merge pull request #51 from MIT-Emerging-Talent/README.md
Goutbi
authored
d67afdd
final edits
sajaabusafia
committed
d2dcdc1
Merge branch 'main' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into word-count-txt-file
sajaabusafia
committed
651afb7
edit the docstring
Omnia-Agabani
committed
0beb468
final edits
sajaabusafia
committed
1620b0f
Merge branch 'main' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into copy-content-from-txt-file-to-another
sajaabusafia
committed
0c36b79
adding the code
Mohamedmxz
committed
ed4f3e3
applied saja's suggestions
ayhm01
committed
a83f7b5
enhancement
Omnia-Agabani
committed
0981225
editing the review comment
RafaaAli
committed
a996b1b
Merge pull request #60 from MIT-Emerging-Talent/ayham/substitution_cipher
ayhm01
authored
8c76054
minor adjustments
ayhm01
committed
5a2a905
delete extra files
RafaaAli
committed
d0503fc
solving ruff issues
RafaaAli
committed
1886a9f
Merge pull request #63 from MIT-Emerging-Talent/ayham/substitution_cipher
ayhm01
authored
ce38391
adding the code tests
Mohamedmxz
committed
88af8f3

Commits on Jan 6, 2025

factorial challenges
Safaishag
committed
2df9d58
summation challenges
Safaishag
committed
2c9177b
Merge pull request #61 from MIT-Emerging-Talent/word-count-txt-file
Omnia-Agabani
authored
e12527d
Merge pull request #30 from MIT-Emerging-Talent/quadratic_sequence
Mayar-Agab
authored
474971d
Fixing merge conflicts
reunicorn1
committed
6bb5b7e
Merge branch 'harmonic_sequence' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into harmonic_sequence
reunicorn1
committed
ea74660
Fixing upon reviewing request
Safi222
committed
0b64d33
Fixing upon reviewing request
Safi222
committed
e8da0cb
Merge pull request #49 from MIT-Emerging-Talent/FooBar_code
Safi222
authored
d0d3cc9
added factorial_calculator
ayhm01
committed
a564612
update factorial implementation
ayhm01
committed
24c85ef
adding a comment
Mohamedmxz
committed
08cc083
adding author and date
Mohamedmxz
committed
567826b
adding author and date
Mohamedmxz
committed
96d0371
added docstring
Safaishag
committed
9f54d05
Merge branch 'Game-greeting' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into Game-greeting
Mohamedmxz
committed
24d67f1
Adding date and author
reunicorn1
committed
2a36a0f
docstring editing
RafaaAli
committed
7329b59
Adding Value error when the variables value is less than 1
reunicorn1
committed
a9dc617
Merge branch 'main' into Game-greeting
reunicorn1
authored
4b55abe
Merge pull request #62 from MIT-Emerging-Talent/Game-greeting
Omnia-Agabani
authored
c5c67da
Merge pull request #23 from MIT-Emerging-Talent/robot
Safi222
authored
489fa6f
fixing the merge conflicts
reunicorn1
committed
013e9a4
Modified files based on Mayar's review
ayhm01
committed
c64c272
Merge pull request #69 from MIT-Emerging-Talent/ayham/factorial_calculator
ayhm01
authored
06019ce
Removing arithemetic sequence test
reunicorn1
committed
a8105d6
Added date
ayhm01
committed
4b364d3
Fixing conflicts
reunicorn1
committed
e525d6d
Merge pull request #18 from MIT-Emerging-Talent/anagrams
sajaabusafia
authored
5bd5719
Fixing failing checks
reunicorn1
committed
240ab59
added factorial calculator
ayhm01
committed
36de9fc
Merge pull request #54 from MIT-Emerging-Talent/Roman_to_integer
RafaaAli
authored
227ced9
Merge pull request #71 from MIT-Emerging-Talent/ayham/substitution_cipher
sajaabusafia
authored
78a486c
added factorial_calculator
ayhm01
committed
19af515
Merge branch 'main' into harmonic_sequence
Goutbi
authored
8d9e90f
Merge pull request #34 from MIT-Emerging-Talent/harmonic_sequence
Goutbi
authored
b0b5b76
Merge pull request #65 from MIT-Emerging-Talent/factorial
Goutbi
authored
65f1c0e
Modified the code by restructuring the if/elif and the parameters names
Goutbi
committed
4d11fb0
Fixing the pytest
Goutbi
committed
7210394
keeping only one in the unittests
Goutbi
committed
8762169
modification
Safaishag
committed
581e942
Merge pull request #75 from MIT-Emerging-Talent/ayham/factorial_calculator
Mohamedmxz
authored
aaaf158
adding a new test
Mohamedmxz
committed
0f1f34b

Commits on Jan 7, 2025

Merge pull request #70 from MIT-Emerging-Talent/lowest_common_ancestor
ayhm01
authored
34c63b5
fixing conflict 1
Goutbi
committed
1a81f85
fixing conflict 2
Goutbi
committed
6c75c29
Merge pull request #64 from MIT-Emerging-Talent/stars-draw
Safaishag
authored
a305ec2
Merge remote-tracking branch 'origin' into Fuel-Gauge
Goutbi
committed
98d37b5
Merge pull request #76 from MIT-Emerging-Talent/fuel-gauge
reunicorn1
authored
931a682
Merge branch 'main' into count_character
reunicorn1
committed
63528c8
fixing conflicts
reunicorn1
committed
71db7ec
Merge branch 'main' into Comminocation_file
reunicorn1
authored
569e0fc
adding docstring
Safaishag
committed
bd8b380
Merge pull request #59 from MIT-Emerging-Talent/copy-content-from-txt-file-to-another
Safaishag
authored
5b191b0
Merge pull request #73 from MIT-Emerging-Talent/count_character
Mohamedmxz
authored
6e5bc40
Merge pull request #35 from MIT-Emerging-Talent/Comminocation_file
sajaabusafia
authored
8e4e1e0
modified file
Safaishag
committed
3d07ec7
Merge pull request #67 from MIT-Emerging-Talent/summation
ayhm01
authored
53a6951
modified the tests and added boundry tests
Goutbi
committed
8a820f7

Commits on Jan 8, 2025

Merge pull request #78 from MIT-Emerging-Talent/armstrong_number
Mayar-Agab
authored
143e8c6
modified file
Safaishag
committed
426e1e2

Commits on Jan 9, 2025

adding word
Safaishag
committed
9adc1c7
Merge pull request #79 from MIT-Emerging-Talent/retrospective
Safi222
authored
2d84195
fixing merge conflicts
Safi222
committed
ac84114

Commits on Jan 12, 2025

addig enhancements
Safi222
committed
5811cba
Merge branch 'lowest_common_ancestor' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-27 into lowest_common_ancestor
Safi222
committed
183829d
adding enhancements
Safi222
committed
4248496
solving conflicts
Safi222
committed
49ea586
solving conflicts
Safi222
committed
f648c98
solving conflicts
Safi222
committed
a0f676d