Skip to content

refactor(ledger): the engine-side citations of the nine colliding backlog numbers move to #1757-#1765 - #1100

Merged
wshallwshall merged 7 commits into
mainfrom
renumber-nine-engine
Sep 13, 2026
Merged

wshallwshall merged 7 commits into
mainfrom
renumber-nine-engine

Conversation

@wshallwshall

Copy link
Copy Markdown
Collaborator

The engine half of the nine-number renumber under BACKLOG #1751. Companion vault PR: wshallwshall/MessageFoundry#1509, which moves the item headings and the maintainer-ledger citations.

Nothing in this PR changes behaviour. Every changed line is a comment, a docstring, or a test/suite title.

The mapping

old which meaning moved new
#232 maintainer ledger: IDE engine-link doctor #1757
#233 engine: Steps view move-drop logic implemented twice #1758
#234 engine: Steps view projection refreshes on save only #1759
#235 engine: Generate Steps view parameter forms from type hints #1760
#236 engine: Test-this-step and test-up-to-step #1761
#237 maintainer ledger: Worktree gate rule-3 fallback #1762
#238 engine: OpenFlow step-attribute completeness pass #1763
#239 engine: Re-measure Steps view estate coverage #1764
#320 maintainer ledger: asvs-verifier-drift raises an alarm #1765

"Engine item" names the MEANING, not the repository. Two of the numbers edited here carry the maintainer-ledger meaning -- #232 in ADR 0110 and its adr/README.md row, and #320 in the two asvs alarm comments -- so no edit was scoped by clone. #237 and #238 have no engine-side citation.

Two ratified ADR headings move

docs/adr/0076-typed-action-vocabulary-action-list-lens.md Amendment C (:575) and Amendment F (:1088) both carry BACKLOG #234 in the heading text, so both slugs change. Zero inbound links point at either slug, measured with a control that fires. The change list accepts this cost explicitly; it is the objection the maintainer-side erratum used to raise against renumbering at all, and that erratum is rewritten in the companion PR.

The irreversible cost

Commit messages are not editable. After this lands, git log --grep '#235' in this repository returns commits that meant the moved item alongside commits that meant the one that stayed, permanently. Measured here: 109 commits across all refs carry BACKLOG #<one of the nine>, 236 carry any #<one of the nine> token (19 of those are squash-merge PR refs in the subject). Each moved item's body in the maintainer ledger now says so.

Pinned deliberately, and why

Checks run

check result
ruff check . pass
ruff format --check . 1289 files already formatted
mypy messagefoundry (strict) Success, 274 source files
pytest tests/test_asvs_scorecard.py tests/test_lens_parse.py tests/test_actions.py tests/test_required_contexts.py 248 passed
pytest docs guards (claude_section_citations, write_share_denominator, cutover_slug_rot, docs_cite_no_refused_config_keys, operator_docs_no_warning_sign) 363 passed
scripts/docs/link_check.py OK, 4,583 relative links in 355 files all resolve
cd ide && npm ci && npm run typecheck && npm run compile exit 0
cd ide && npm run test:unit 659 passing

Not run locally: the full pytest suite (the vault extra is absent from this interpreter, so gated modules removed themselves at collection), and every hosted-runner-only leg. Those must be read on the PR.

Not enqueued -- the queue is the Lander's.

wshallwshall added 7 commits September 13, 2026 13:38
…to #1757

Both ledgers held a #232: the vault's "IDE engine-link doctor" (which ADR 0110
records) and the engine's "Steps view for routers". Under the #1751
reconciliation the vault side takes a new number, so the two citations of it in
this repository move with it. Nothing engine-side named #232 changes.

Git history is not editable. `git log --grep '#232'` still resolves to the
pre-renumber meaning, permanently.
Both ledgers held a #233: this repository's "Steps view move-drop logic
implemented twice" and the maintainer ledger's "Connection present but not
deployed". Under the #1751 reconciliation the engine-meaning item takes a new
number, so its citations in ADR 0076, the webview mirror hook and the three
Steps suites move with it. Comments and test titles only -- no behaviour change.

Git history is not editable. `git log --grep '#233'` still resolves to the
pre-renumber meaning, permanently.
Both ledgers held a #234: this repository's "Steps view projection refreshes on
save only" and the maintainer ledger's "connections.toml GUI save silently
strips per-connection fields". Under the #1751 reconciliation the engine-meaning
item takes a new number.

Two RATIFIED ADR 0076 section headings carry it and move with it -- Amendment C
and Amendment F. Zero inbound links point at either slug, measured. Everything
else here is comments and test titles; no behaviour changes.

Git history is not editable. `git log --grep '#234'` still resolves to the
pre-renumber meaning, permanently.
Both ledgers held a #235: this repository's "Generate Steps view parameter forms
from Python type hints" and the maintainer ledger's ADR 0006 reference-sets port.
Under the #1751 reconciliation the engine-meaning item takes a new number.

Pinned on purpose: docs/adr/0006's section heading and the three links to it,
and both tests/test_database_connector_integration.py sites -- the test cites
PULL REQUEST 235, merged 2026-06-14, six weeks before either item was filed.

Comments and test titles only; no behaviour changes.

Git history is not editable. `git log --grep '#235'` still resolves to the
pre-renumber meaning, permanently.
Both ledgers held a #236: this repository's "Test-this-step and test-up-to-step"
and the maintainer ledger's "SOAP body secrets". Under the #1751 reconciliation
the engine-meaning item takes a new number.

Pinned on purpose: ADR 0015 and docs/CONNECTIONS.md keep their #236 headings
(SOAP meaning), and tests/test_connscale_empty_claims_per_msg.py:1202 / :1236
keep theirs -- that citation is a third sense whose work is BACKLOG #1211 limb
one, matching neither item.

Comments and test titles only; no behaviour changes.

Git history is not editable. `git log --grep '#236'` still resolves to the
pre-renumber meaning, permanently.
Both ledgers held a #239: this repository's "Re-measure Steps view estate
coverage" and the maintainer ledger's "Windows tray service-manager". Under the
#1751 reconciliation the engine-meaning item takes a new number, so the ADR 0076
A.8 references and the lens_coverage.py docstring move with it. Comments only.

Git history is not editable. `git log --grep '#239'` still resolves to the
pre-renumber meaning, permanently.
Both ledgers held a #320: the maintainer ledger's "asvs-verifier-drift raises an
alarm nothing closes" and this repository's "windows-2025 is the slowest CI leg".
Under the #1751 reconciliation the vault-meaning item takes a new number, so the
two comments in this repository that name the alarm antipattern move with it.
This repository's own #320 item is untouched. Comments only.

Git history is not editable. `git log --grep '#320'` still resolves to the
pre-renumber meaning, permanently.
@wshallwshall
wshallwshall added this pull request to the merge queue Sep 13, 2026
Merged via the queue into main with commit 2a1437e Sep 13, 2026
44 checks passed
@wshallwshall
wshallwshall deleted the renumber-nine-engine branch September 13, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant