Repository navigation
benchmark: -t takes a comma-separated list of profiles - #1701
Merged
Merged
Conversation
A change that touches several profiles had two ways to be measured, both
wrong for it. One -t run per profile is one approval and one results commit
each, posted only after the previous run finishes, because a PR holds one
pending run; seven touched profiles is a day of polling the thread. A full
--save is one approval but re-measures every profile, and moves the untouched
ones by several percent of machine noise (gateway-64 +15%, production-stack
-4% in one run), so the real change arrives mixed with drift.
-t now accepts a comma-separated list, one job, one approval, one results
commit, and only the named profiles are touched:
/benchmark -f morojs -t gateway-h3,gateway-64,production-stack --save
benchmark.sh resolves the list at argument parsing, in the order given with
duplicates dropped, and a name that is not a profile fails there, before any
image is built or the host tuned; previously an explicit typo was warned past
and the run measured nothing while looking like a run. benchmark-lite.sh does
the same against its own table. compare.sh filters on the set.
pr-commands.yml checks every name in the list with the same pattern as
before. A list with a name that fails the check is rejected with a comment
instead of being reduced to an empty profile: an empty profile means "all
tests", and with --save that dispatched a full run nobody asked for, which is
exactly how an illustrative example in a PR comment on MDA2AV#1699 queued one. The
all-frameworks resolution in both workflows subscribes a framework when it
runs any profile in the list; benchmark.sh skips the ones it does not.
README, the PR template and the running-locally docs gain the list form.
M-Chris
requested review from
Kaliumhexacyanoferrat and
MDA2AV
as code owners
November 3, 2026 00:26
Contributor
Author
|
@MDA2AV heres the change we just talked about |
MDA2AV
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change that touches several profiles had two ways to be measured, both wrong for it. One -t run per profile is one approval and one results commit each, posted only after the previous run finishes, because a PR holds one pending run; seven touched profiles is a day of polling the thread. A full --save is one approval but re-measures every profile, and moves the untouched ones by several percent of machine noise (gateway-64 +15%, production-stack -4% in one run), so the real change arrives mixed with drift.
-t now accepts a comma-separated list, one job, one approval, one results commit, and only the named profiles are touched:
benchmark.sh resolves the list at argument parsing, in the order given with duplicates dropped, and a name that is not a profile fails there, before any image is built or the host tuned; previously an explicit typo was warned past and the run measured nothing while looking like a run. benchmark-lite.sh does the same against its own table. compare.sh filters on the set.
pr-commands.yml checks every name in the list with the same pattern as before. A list with a name that fails the check is rejected with a comment instead of being reduced to an empty profile: an empty profile means "all tests", and with --save that dispatched a full run nobody asked for, which is exactly how an illustrative example in a PR comment on #1699 queued one. The all-frameworks resolution in both workflows subscribes a framework when it runs any profile in the list; benchmark.sh skips the ones it does not.
README, the PR template and the running-locally docs gain the list form.
Description
PR Commands — comment on this PR to trigger (requires collaborator approval):
/benchmark -f <framework>/benchmark -f <framework> -t <test>/benchmark -f <framework> --save/benchmark -f <framework> -t <test> --save/benchmark -f <framework> --compare <other>/benchmark-multiple -f <fw1>,<fw2>,...-tand--savetoo; saved results land in a single commit/benchmark-multiple --save-fneeded: benchmark and save every framework the PR touches/benchmark-test -t <test><test>and save the resultsFor
/benchmark, always specify-f <framework>; the flags combine in any order. Results come back as a comment with a per-profile table of RPS, p99, CPU and memory — one table per framework on multi runs. A new benchmark comment while a run is in flight queues behind it (one deep) instead of cancelling it. For multi-framework PRs (dependency bumps, same-language refactors) prefer/benchmark-multiple, which runs everything in a single job and commits all saved results together, so no run overwrites another.--compareworks on single-framework runs only.What the deltas are measured against. By default, this framework's own results published on
main- answering "did this change help?". When you are tuning a variant or a successor entry,--comparere-bases them on another entry instead:The reply states which baseline it used, and profiles the other framework does not run show
n/arather than a delta.Run benchmarks locally
You can validate and benchmark your framework locally with the lite script — no CPU pinning, fixed connection counts, all load generators run in Docker.
Requirements: Docker Engine on Linux. Load generators (gcannon, h2load, h2load-h3, wrk) are built as self-contained Docker images on first run.