source integration 배달 주문 도메인, statics domain 작업 - #9
Open
moonlt93 wants to merge 40 commits into
Open
Conversation
Delog 15 be 배달정보 저장 user auth init
chore: username 추가로 인한 mapper 및 context.set 추가
chore : globalExceptionHandler와 swagger 간 ex catch 및 버전 문제 해결
qlido
approved these changes
Jul 17, 2025
qlido
left a comment
qlido
left a comment
Collaborator
There was a problem hiding this comment.
일단 회사에서 보이는 대로 적어봤는데 큰건 아니라 확ㄷ인만 해주시고 배포 ㄱㄱ
| WHERE o.username = :username | ||
| AND o.orderDateTime BETWEEN :startDate AND :endDate | ||
| """, | ||
| ) |
Collaborator
There was a problem hiding this comment.
따로 query annotation 사용하신 이유가 있나요?
Author
There was a problem hiding this comment.
ㅋㅋㅋ 따로 쿼리 작성하는게 익숙해서 쓴거라 큰 이유는 없습니다.
Comment on lines
+29
to
+33
| val entity = | ||
| deliveryOrderRepository | ||
| .findById(id) | ||
| .orElseThrow { EntityNotFoundException("해당 ID의 주문을 찾을 수 없습니다: $id") } | ||
| return deliveryOrderMapper.toResponse(entity) |
Author
There was a problem hiding this comment.
이거 그럼 command 랑 query 제가 분리하겠습니다.
| val gaps = calculateWeeklyOrderGapsInDays(deliveryOrderList, startDate, endDate) | ||
|
|
||
| return Stats( | ||
| 0L, |
Collaborator
There was a problem hiding this comment.
null이나 기본값을 사용해주시고 명시적인 매직 넘버는 지양 부탁드립니다
Comment on lines
+50
to
+56
| @ElementCollection | ||
| @CollectionTable( | ||
| name = "delivery_orderId_list", | ||
| joinColumns = [JoinColumn(name = "statsId")], | ||
| uniqueConstraints = [UniqueConstraint(columnNames = ["statsId", "deliveryOrderIdList"])], | ||
| ) | ||
| val deliveryOrderIdList: List<Long> = listOf(), |
Collaborator
There was a problem hiding this comment.
이것도 저희가 관리하게 테이블로 분리해주시면 좋겠습니다
| uniqueConstraints = [UniqueConstraint(columnNames = ["statsId", "deliveryOrderIdList"])], | ||
| ) | ||
| val deliveryOrderIdList: List<Long> = listOf(), | ||
| @CreatedDate |
Collaborator
There was a problem hiding this comment.
hibernate CreationTimestamp 쓰면 jpaaudit이 필요없어요 (TMI)
| ItemProcessor { usernames -> | ||
| val results = mutableListOf<Stats>() | ||
| val currentDate = LocalDate.now() | ||
|
|
Author
There was a problem hiding this comment.
비동기 Future를 쓴다는게 Thread 단위로 작성하는 패턴이 고런게 있는건가요
Comment on lines
+79
to
+98
| companion object { | ||
| private class MonthlyBuilder { | ||
| private var deliveryCount = 0 | ||
| private var orderMenuCount = 0 | ||
| private var totalSpent = BigInteger.ZERO | ||
| private var summaryMonth = 0 | ||
|
|
||
| fun add(entity: StatisticsEntity) = | ||
| apply { | ||
| deliveryCount += entity.totalOrderCount | ||
| orderMenuCount += entity.totalItemCount | ||
| totalSpent += entity.totalSpent | ||
| summaryMonth = entity.summaryStartDate.monthValue | ||
| } | ||
|
|
||
| fun build(): StatisticsMonthlyResponse = | ||
| StatisticsMonthlyResponse( | ||
| deliveryCount = deliveryCount, | ||
| orderMenuCount = orderMenuCount, | ||
| totalSpent = totalSpent, |
Author
There was a problem hiding this comment.
data class 얕은 복사 관련해서 방어적으로 작성하는 방법중에 하나라고 해서 작성했는데
과한가요?
| } | ||
|
|
||
| fun getAllUsernames(currentDate: LocalDate): List<String> { | ||
| val endDate = currentDate.minusDays(1).atTime(23, 59, 59) |
Collaborator
There was a problem hiding this comment.
LocalTime.MAX 이런거 사용하시는거 어떨까요?
Author
There was a problem hiding this comment.
아 LocalTime.MAX의 존재를 몰랐습니다. 감사합니다.
|
|
||
| private fun getYearMonth(month: Int): YearMonth { | ||
| val currentYear = LocalDate.now().year | ||
| val yearMonth = YearMonth.of(currentYear, month) |
Author
There was a problem hiding this comment.
조금 고민되던 부분이었는데 년-월 formatting 해서 작성하겠습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
주요 feature