fix(ir): parenthesize CellUV base in Swizzle expressions - #9
Merged
Merged
Conversation
- Print's Swizzle case appended ".field" to CellUV without parentheses, causing swizzles to bind to the division denominator in WGSL/Metal (e.g. `a / b.x` instead of `(a / b).x`) - Add targeted parenthesization in Print's Swizzle case for CellUV to ensure correct precedence without affecting bare CellUV usage - Add regression tests for swizzled and bare CellUV print output - Add conformance test material and goldens exercising inline `cell.uv` swizzles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a precedence bug where inline
cell.uv.xexpressions in WGSL and Metal backends produced incorrect output. Both dialects renderCellUVas an unparenthesized division expression, so appending.fieldwithout parentheses bound the swizzle to the denominator instead of the entire UV, e.g.a / b.xinstead of(a / b).x. GLSL and GLES renderCellUVas the bare varyingvUV, so they were not affected.Changes
CellUVspecifically inir.Print's Swizzle case so inline swizzled access renders as(a / b).xCellUVoutput is unchangedwater-sim-inline-cell-uvwith golden outputs for all backends (GLES, GLSL, Metal, WGSL)Testing