fix(emit): avoid division by zero in point sprite NDC offset - #5
Merged
Conversation
- Clamp viewport dimensions to 1.0 minimum to prevent division by zero during point sprite NDC offset calculation - Prevent NaN/undefined behavior when viewport width or height is zero - Update Metal and WGSL emitters and golden test files
odvcencio
force-pushed
the
fix/viewport-div-guard
branch
from
July 27, 2026 05:00
5d1b829 to
c03b7d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents a division-by-zero crash when calculating NDC offsets for point sprites. Previously, the vertex shader divided directly by the viewport width and height, which can occasionally be zero. The fix clamps these dimensions to at least 1.0 before the division.
Changes
Testing
go test ./...to verify conformance tests pass and golden files are up to date.