Repository navigation
fix: reject dangerous module ids in run_action - #228
Merged
Merged
Conversation
run_action concatenated the id into the action.sh path with no check, so .. was resolved and the script ran as root. Use the same id pattern as zip install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_actionconcatenates the module id into/data/adb/modules/{id}/action.shwith no validation...in the id is resolved, so the action script can sit outside the module directory and is executed as root. A local app can use this to escalate to root. For example:Reject ids that do not match the same pattern already used at zip install.