feat(web): welcome page and workspace route split - #29
Merged
Conversation
Opening the site dropped you straight into the demo organisation's dashboard with no explanation of what the product is or whose data you were looking at. Route groups split the two concerns without changing a single existing URL: (marketing) has no sidebar and owns /, (app) carries the workspace chrome and everything else. The dashboard moves to /dashboard. The welcome page leads with the argument rather than the feature list — that 'two people must approve' only ever verified two accounts clicking a button — and names the three refusals with the codes the domain layer actually returns. It says plainly that there is no account system yet and that the demo organisation is shared and synthetic, so nobody mistakes it for their own workspace. Also fixes the mobile nav, which had seven columns for eight items and was dropping one off the bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the site dropped visitors straight into the demo organisation's dashboard with no explanation of the product or whose data they were seeing.
Route groups split marketing from workspace without changing any existing URL:
//dashboard/)The welcome page leads with the argument — that "two people must approve" only ever verified two accounts clicking a button — and names the three refusals using the codes the domain layer actually returns. It states plainly that there is no account system yet and that the demo organisation is shared and synthetic.
Also fixes the mobile nav, which had
grid-cols-7for eight items and was dropping one.lint·typecheck· 363 tests ·buildgreen.