Repository navigation
Fixed the issue where compress_to_size damaged files on macOS - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I'm trying to fix caesium-image-compressor in the isuue #369, but I noticed that you have fixed the problem caused by color space. However, there are still some very minor problems. When
input_path == output_path, self-copying sometimes has the problem of damaged the file. The test examples are as follows:Software version
0.20.0
Operating System information
macOS 15.7.3 (24G419)
To Reproduce
Copy this picture to the root directory.
cargo run --example size -- ./test_img.webp ./test_img.webpThe output image is damaged.