Skip to content

fix(benchmarks): clear remaining CodeQL diagnostics - #31

Merged
LurigeLars merged 1 commit into
mainfrom
fix/codeql-benchmark-lints-20261101
Nov 1, 2026
Merged

LurigeLars merged 1 commit into
mainfrom
fix/codeql-benchmark-lints-20261101

Conversation

@LurigeLars

Copy link
Copy Markdown
Owner

Why

Following the v5.3.3 upstream merge, CodeQL reported four non-blocking findings in benchmark-only Python code (alerts DietrichGebert#71–DietrichGebert#74).

Changes

  • Remove one redundant in-function json import; use already imported json module.
  • Stop returning the result from pairwise() and run(), both procedures invoked by answer.py CLI; preserve their existing side effects.
  • Explicitly return None from the judge retry function if zero attempts were made.

No benchmark logic, CI configuration, dependency or plugin runtime changes. Existing tests and CodeQL must pass before merging. No paid benchmark calls executed.

Resolve four non-blocking CodeQL diagnostics without altering benchmark scoring or CLI behavior.
@LurigeLars
LurigeLars merged commit 9dba5f6 into main Nov 1, 2026
5 checks passed
@LurigeLars
LurigeLars deleted the fix/codeql-benchmark-lints-20261101 branch November 1, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant