Repository navigation
Conversation
resume="interpolated" appended its position to the interpolated_resumes annotation only after the run closed, on the success path, so a stopped or failed continuation left planes beyond the position and no record of it. The session loop now writes the annotation beside the run summary, before the first step, when Simulation.run says the start is an interpolated plane (run_problem's new interpolated_resume keyword). The issue's other route, deriving the record from SEP 42's execution record entry for forced resumes, is not available: SEP 42 was superseded by ADR-066 and that entry never existed, and the execution record is replaced by each execution, so it cannot hold the earlier positions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
optmat 0.9.1 ends some ModelRangeWarning texts, the Raman responses' density and temperature warnings among them, with ids of its internal tracker such as "(TC-527, TC-688)". solprop forwarded the text unchanged into MaterialRangeWarning and the run's material record, so users got a reference they cannot look up. _optmat.optmat_text removes a parenthesis that holds only such ids and keeps the rest of the text. It is applied wherever optmat's warning text is passed on: the Raman responses' _reemit, the ionisation rates' warnings at resolution (which carry no ids in 0.9.1) and the material bridge's range and absorption warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
jtravs
marked this pull request as ready for review
November 13, 2026 21:32
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Documentation build overview
20 files changed ·
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resume="interpolated"leaves nointerpolated_resumesrecord #152:interpolated_resumesis written before aresume="interpolated"session's first step, beside the run summary, so a stopped or failed continuation still records where it restarted. The SEP 42 execution-record route the issue preferred isn't available: SEP 42 was superseded by ADR-066, and the execution record is replaced by each session. Interface note:run_problemgains aninterpolated_resume: bool = Falsekeyword, the way to pass this fact to the session loop without touching theStartseam. The annotation stays outside the configuration hash. A session stopped before saving a plane and resumed from the same plane records that position twice; that is still accurate.(TC-n[, TC-m])) are stripped from the optmat warning texts solprop forwards (Raman responses, ionisation rates, material bridge), in both the warning and the run's record. Other parentheses are kept. If optmat changes its id form (Warnings reach solprop's users carrying register numbers optmat#32), the pattern will need revisiting.Closes #152
Closes #166
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH