Repository navigation
GUI: take a route's description once, so its sheet is built once (Windows QLabel flake) - #820
Merged
Merged
Conversation
A setup's route is described ahead (the warm-up prefetch) and again when the setup opens if no answer has been taken yet. When the window's thread is slow, the reply filter accepts the first answer before the second question is sent, so both answers reach the document, `described` fires twice and the sheet is rebuilt, deleting every widget of the first build. Tests that held a derived number's label across that rebuild failed on Windows CI with "Internal C++ object (QLabel) already deleted". A second answer for a known route is now ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
jtravs
marked this pull request as ready for review
November 13, 2026 21:31
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A setup's route is described twice: once when the window fetches it ahead, and again when the setup opens before that first answer has been taken.
ReplyFilterkeeps only the newest request's reply, but it runs on the reader thread. When the window thread is slow (typical on Windows CI), the reader accepts the first answer before the second request exists, so both answers reach the document.describedthen fires twice and the sheet is rebuilt, which deletes every widget from the first build. Tests that held a derived number's label across that rebuild failed withInternal C++ object (QLabel) already deleted.test_ui_workflow.py:916, :1429, :1450). With the fix and the same delay, each class is built once and all three pass.gui/src/solprop_gui/ui/document.py): the document ignores a second describe answer for a route it already holds. Descriptions never change while the kernel runs. This also removes a pointless full sheet rebuild that would hide an open target editor.Closes #791
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH