Repository navigation
Conversation
Every snapshot attempt set the 60 s retry time, and a successful publication never cleared it, so `_due` held interval-driven snapshots until 60 s had passed: an interval below 60 s acted as 60 s. A successful publication now clears the back-off, which applies only after a failed or deferred attempt. Closes #600 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
`axis_node` matched a Radau rule's node against only the first n_pol
rows of the on-axis synthesis. On a one-component transform whose modes
have a y field on the axis (a rotated mode on components=("x",)), the
x-only node scan stood in for the two-row axis row, losing the y field
(the hypot on a field grid, the polarisation ellipse on an envelope
grid). The node is now declined whenever the axis has a nonzero row the
transform does not carry, so both numpy_ref and native (whose plan takes
its node from the same function) scan the axis row.
Closes #663
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
jtravs
marked this pull request as ready for review
November 13, 2026 19:30
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Documentation build overview
25 files changed ·
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interval_secondsbelow 60 acted as 60. Regression test with a fake monotonic clock.populations.axis_nodedeclines a Radau rule's axis node when the axis has a nonzero row that the transform does not carry (for example, a rotated mode oncomponents=("x",)). Before the fix, on-axis electron density came out as 2.6e13 against the row scan's 2.8e21. numpy_ref and native both take their node from this function; the regression test checks both backends against numpy_ref's row scan.Closes #600
Closes #663
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH