Repository navigation
Conversation
capabilities.output stated every basis's field in sqrt(W) and its power, energy and spectral density as modal quantities. A spatial file stores its field in V m (radial), V/m (Cartesian, line) or sqrt(W/m) per y frequency (planar), and the readers of its power, energy and spectral density refuse it. The statement, and a plane view's quantities, now give a spatial file only its field, in its route's unit; the modal statements are unchanged. Closes #425 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
The note sent readers to the first experiment of stepper.md section 9, which now lists no experiments, only a link to the open questions. It now names the open question and its issue. Refs #259 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
…ands The guide recommended carrier_frame="scalar" for comb-to-continuum runs without saying that a weak driven band still forming near the launch comes out a few hundred times less accurate than with the default at matched total-field error, as the carrier-frame section of adams.md records. Refs #253 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
…power Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
jtravs
marked this pull request as ready for review
November 13, 2026 19:29
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
capabilities.py imported the private route helper across packages, over the size report's cap; the capability module now states the unit itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH
Documentation build overview
33 files changed ·
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capabilities.output(andPlaneView.quantities) gives a spatial file only itsfield, a coordinate quantity in the route's stored unit (V m radial, V/m Cartesian and line, sqrt(W/m) per y frequency planar). Power, energy and spectral density are no longer stated for a spatial file; their readers already refuse it, asrefused_readerssays. The modal and general-modal statements are unchanged and now pinned by a test. API note:quantities["power"]on a spatial file is now aKeyError. Nothing in the repository indexes it.weighted_norm_scalestill points at an experiment that is not listed #259 (docs part):weighted_norm_scale's provisional note points at the open question indocs/dev/open-questions.mdinstead of a section-9 experiment list that no longer exists. The measurement itself stays open.Multistep(carrier_frame="scalar")loses weak driven bands the step-size norm does not see, and two of its costs are unexplained #253 (docs part): the stepper guide's carrier-frame recommendation warns that it loses a weak driven band still forming near the launch.capabilities.outputfor spatial power.Closes #425
Refs #259
Refs #253
🤖 Generated with Claude Code
https://claude.ai/code/session_01XGENPwwkUUG9KSAwneHjgH