Add skinning support for judgements - #900
Open
LumpBloom7 wants to merge 22 commits into
Open
Conversation
Just the config file for now
No good reason to handroll the same thing
Now with more similarities to Argon judgements for std/mania
This should really be replaced in the future in-favour of a ruleset agnostic implementation
Only for use in test scenes
This is no longer the case
Miss/{n}.png works for animation
Miss.png works for a single frame
Just the config file for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #899
The custom judgement drawables defined by sentakki have been dropped in favour of reusing existing judgement classes such as
JudgementPoolerandDrawableJudgement.Also:
Tweaked existing sentakki judgement visuals to more closely match their std/mania counterparts. This is now exclusive to the Argon skins.
Added judgement variant that matches the Triangles design, the new default when no other variant is found
All variants provide support for timing indicators. This is implemented to maintain parity with the existing support of it. It will be dropped in favour of a more standard implementation once ppy/osu#36845 is resolved upstream.
Legacy skinning support
Support has been added for skinning the judgements. All judgements support animation in the standard way by appending
-{n}to the filename. As per every other skinnable element in osu, HD versions can be provided by appending@2x.sentakki/judgements/Critical[/{n}][@2x]sentakki/judgements/Perfect[/{n}][@2x]sentakki/judgements/Great[/{n}][@2x]sentakki/judgements/Good[/{n}][@2x]sentakki/judgements/Miss[/{n}][@2x]Timing indicators can also be skinned and animated.
sentakki/judgements/early/[/{n}][@2x]sentakki/judgements/late[/{n}][@2x]Showcase
recording.2026-07-29.16-46-39.mp4