Make MultiPeek consistent with Peekable#1
Open
mysteriouslyseeing wants to merge 3 commits into
Open
Conversation
Added next_if, nth_if, next_if_eq and nth_if_eq, making multipeek a drop-in replacement for std's Peekable.
Author
|
I just realised that this is not enough; peek_mut (and peek_nth_mut) are also required. I'll add them to the PR in the morning. |
Added the peek_mut and peek_nth_mut methods
Author
|
I've now added the two methods that were missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MultiPeek is missing 2 methods from Peekable: next_if and next_if_eq. This pull request adds those two methods and two additional ones: nth_if and nth_if_eq. This will make MultiPeek a drop-in replacement for Peekable in the standard library.
Description of changes:
Added next_if, nth_if, next_if_eq and nth_if_eq.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.