fix(ui): replace Dottore jumping-jacks loading gif with a normal spinner - #8
Merged
Merged
Conversation
Swap the `/sprites/dottore/dottore_jumping.gif` loading animation for a standard Loader2 spinner in both places it appeared: the "Prof Mari is working..." indicator (ProfessorMariWorkingWindow) and the "DJ Mari is composing a playlist" toast (SpotifyMiniPlayer). Also drops the now-unused gif constant, the image-failure fallback state, and the unused React hook imports from the working window. The gif asset file itself is left in place (now unused).
✅ Bunny Review CompletedTip Review posted. The specimen has left the observation table.
|
🐰 Bunny ReviewBunny Merge Signal: ReadyTip READY
Note Mode: 🧭 Specimen Summary
🔎 Isolated DefectsTip No actionable defects isolated. 🧹 Nitpicks
✅ Control Checks
🧪 Observations
🧰 CI Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The "Prof Mari is working..." indicator and the "DJ Mari is composing a playlist" toast used a custom Dottore jumping-jacks gif as their loading animation. This is my personal fork and I'd rather have a plain, standard loading spinner there.
What
Replaces the
/sprites/dottore/dottore_jumping.gifloading animation with the standardLoader2spinner (the same one used elsewhere in the app) in both places it appeared:ProfessorMariWorkingWindow.tsx— the "Prof Mari is working..." indicator. Also drops the now-unused gif constant, the image-load-failure fallback state, and the unused React hook imports.SpotifyMiniPlayer.tsx— the "DJ Mari is composing a playlist for you, hold on tight!" toast. Drops the now-unused gif constant.The gif asset file itself is left in place (now unused).
pnpm check(typecheck + lint + build) passes.