fix(security): contain skill file writes within the skill directory#95
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Installer now verifies each skill file's resolved path stays inside the skill cache directory before writing it, throwing unsafeSkillPath for any '..' traversal in a remote-supplied relative path. Defence-in-depth against a malicious skill repository attempting path traversal.
albertodebortoli
force-pushed
the
security/contain-skill-writes
branch
from
b65eda2 to
e57ff3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
skillFolder.appendingPathComponent(skillFile.relativePath). The relative path originates from a remote repository. Git itself will not normally produce..path components, but there was no defensive check that the resolved write path stays inside the skill directory, leaving a path-traversal sink fed by remote data.Installernow verifies each skill file's resolved path is contained within the skill cache directory before writing, throwingunsafeSkillPathfor any entry that escapes via... Containment is computed lexically withstandardizedFileURL, so it is safe to evaluate before the file exists.Type of Change
How Has This Been Tested?
swift buildandswift testlocally on macOS (arm64).New test: a skill download whose file carries a
../../escaped.txtrelative path is rejected, and the install confirms nothing is written outside the skill cache folder.Checklist
Breaking Changes?
Additional Notes
Part of a set of independent supply-chain hardening changes; this PR stands alone and can be merged on its own.