fix(security): warn when verifying with a broken hash algorithm#93
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ToolInstaller now emits a danger-styled warning when a tool is verified with MD5 or SHA-1, both of which are collision-broken and forgeable by an attacker who controls the download. Adds ChecksumAlgorithm.isCryptographicallyWeak.
11aa451 to
6fc4290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ToolInstallernow emits a danger-styled warning when a tool is verified with MD5 or SHA-1, recommending sha256/sha512. AddsChecksumAlgorithm.isCryptographicallyWeakto centralise the classification.Type of Change
How Has This Been Tested?
swift buildandswift testlocally on macOS (arm64).New test: parameterised
isCryptographicallyWeakcoverage (md5/sha1 → true, sha256/sha512 → false). Existing checksum-validation tests still pass.Checklist
Breaking Changes?
Additional Notes
Part of a set of independent supply-chain hardening changes; this PR stands alone and can be merged on its own.