fix: HashTable.all() skips entries keyed 0n#115
Closed
ejtriple wants to merge 1 commit into
Closed
Conversation
0n is a valid key (Linkable.key defaults to 0n) but all()/findnext used it as the bucket-sentinel marker, so a 0n entry and anything behind it in its bucket were skipped (find() still returned them). Iterate by sentinel identity. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Author
|
Closing - Probably need to revisit IPv6 handling instead of this approach. Now two people (with different ips) will be mapped to the same player, which is no bueno. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linkable.keydefaults to0n, butall()/findnextusedkey === 0nas the bucket-sentinel marker. So a real entry keyed0n— and anything inserted behind it in the same bucket — was skipped byall(), even thoughfind()(which terminates on sentinel identity) still returned it.Fix: iterate
all()by sentinel identity likefind()already does, and drop the now-unusedfindnext.0nbecomes a valid key.