chore: [289] migrate thieving stall logic to marketthief varbits

[ewby]

this updates the existing thieving stall logic (minus miscellania and etceteria) to use the new marketthief_* varbits and retire the old thieving_stall_timer varp.

marketthief_* is new to 289 and makes the code more readable and allows the unpacking of a really bloated thieving_stall_timer varp. no more setbit, testbit, and clearbit for each stall index, now it's handled by the nicely named varbits.

also did housecleaning and removed related old definitions and stall index constants. updated the cheat_reset.rs2 runescript to %marketthief = 0, but it should be noted that this also resets the miscellania/etceteria varbits as well. i did this so there wouldn't be like 10 lines of %marketthief_cake = 0, %marketthief_silk = 0, %marketthief_tea= 0, etc.

Big thanks to @Indio3 for the idea and guidance!

[AmVoidGuy]

You can't add or remove varps because it'll break crcs since they come from the client cache, but you can rename it if you want

[ewby]

traveling today, sorry for the late reply. i appreciate the insight! will get this fixed tonight and learn more about the server compilation process to avoid breaking anything in the future.

similar thing to what you brought up but im also seeing thieving_stall_timer here:

• https://github.com/LostCityRS/Content/blob/274/scripts/_unpack/225/all.varp

im still learning about how the clients compile and depend on eachother for their game cache (assuming since they’re different each revision and no redundant definitions), I can’t remove/rename that definition though because previous versions depend on it right? and therefore if I were to remove/rename it globally from varp.pack wouldn’t that break some stuff?

or when the server prompts you to select a revision it definitely could just be downloading the branch specific to what you chose, and this is 289 so that doesn’t matter. again, will be giving this a try locally tonight to see.

[ewby]

@AmVoidGuy

added the varp back and renamed as you mentioned, i like this rather than keeping it as 138=thieving_stall_timer for readability and general understanding.

also tested my fears for the _unpack/225/all.varp changes, removed the [thieving_stall_timer] definition and replaced with [varp_138], no compile errors and thieving functions as expected. idk why i was so worried about it, i thought this was gonna affect 225 compiling or something lol

thank you for the feedback so far!