Skip to content

No-op: player profile schema documentation is already on main - #28

Closed
ibloud with Copilot wants to merge 1 commit into
mainfrom
copilot/merge-player-profile-schema-docs
Closed

No-op: player profile schema documentation is already on main#28
ibloud with Copilot wants to merge 1 commit into
mainfrom
copilot/merge-player-profile-schema-docs

Conversation

Copilot AI commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR was intended to merge the Player Profile System v1 schema documentation from commit 014285d into main. Repository inspection showed that main already contains that commit and the docs/design/player-profile-schema.md content matches exactly.

  • Outcome

    • No repository changes are included in this PR.
    • The requested schema documentation is already present on main.
  • Verified scope

    • docs/design/player-profile-schema.md is present under docs/design/
    • The file content matches commit 014285d310a71fa9742ef62c524774958776f384
    • origin/main already includes the target commit
  • Documentation covered by the existing commit

    • Player Profile System v1 vision and philosophy
    • Firestore schema for veiled_dominion_rooms, matchLogs, and playerProfiles
    • Pre-DID identity bridging and AT Proto Phase 2 plan
    • Telemetry model, derived mechanics, ethics, roadmap, and open questions

Copilot AI changed the title [WIP] Merge player profile schema documentation into main No-op: player profile schema documentation is already on main Aug 21, 2026
Copilot AI requested a review from ibloud August 21, 2026 01:16
ibloud added a commit that referenced this pull request Aug 21, 2026
@ibloud

ibloud commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Resolution: Open Question 2 — isReadyToAdvance() timing

Decision: Post-game snapshot approach (deferred).

For Phase 1, rebirthReady will remain a post-game boolean checked by the aggregator in Issue 2, not a per-move field in Issue 1. This simplifies telemetry capture and matches the current engine.isReadyToAdvance() API.

The edge case identified (mid-game advance condition triggered then resolved before game-over) is treated as deferred scope. If playtesting data surfaces this as a critical issue, we will flag a follow-up issue to:

  • Track rebirthReady as a per-move flag in MoveEntry
  • Update the aggregator to check the full move history rather than just the final board state

Rationale:

  • Phase 1 prioritizes minimal telemetry surface area and fast aggregation
  • The post-game snapshot approach is sufficient for Sealed Deck gate logic
  • Per-move tracking adds ~32 bytes per move (~5KB/match overhead) without clear benefit until playtesting reveals the edge case matters in practice

This keeps Issue 1 (Telemetry Capture) focused and unblocks Issue 2 (Post-Game Aggregator) without schema rework.

@ibloud ibloud closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants