feat(onboarding): Add OnboardingViewModel tests and improve effect handling

app/src/main/java/com/london/app/navigation/graph/onboardingNavGraph.kt

@@ -24,7 +24,7 @@ fun NavGraphBuilder.onboardingNavGraph(
     composable<OnBoarding.Welcome> {
         WelcomeScreen(
             onNavigateLogin = navController::navigateToAuthGraph,
-            onNavigateContinue = navController::navigateToMainGraph
+            onNavigateAsGuest = navController::navigateToMainGraph
         )
     }
 }

data/src/main/java/com/london/data/local/database/dao/recent/search/RecentSearchDao.kt

@@ -35,5 +35,5 @@ interface RecentSearchDao : RecentDao<RecentSearchLocal> {
 
     @Delete
     suspend fun delete(item: RecentSearchLocal)
-    
+
 }

presentation/src/main/java/com/london/presentation/feature/details/tvshow/episode/EpisodeDetailScreen.kt

@@ -124,7 +124,9 @@ private fun Content(
     ) {
 
         BackgroundGradient(
-            modifier = Modifier.align(Alignment.TopStart).zIndex(2f)
+            modifier = Modifier
+                .align(Alignment.TopStart)
+                .zIndex(2f)
         )
 
         TopBar(

presentation/src/main/java/com/london/presentation/feature/details/tvshow/episode/EpisodeDetailsViewModel.kt

@@ -32,7 +32,7 @@ class EpisodeDetailsViewModel @Inject constructor(
         getEpisodeDetails()
     }
 
-    private fun getEpisodeDetails(){
+    private fun getEpisodeDetails() {
         loadEpisodeDetails()
         loadEpisodeRating()
         loadVideoProvider()

presentation/src/main/java/com/london/presentation/feature/home/HomeScreen.kt

@@ -181,10 +181,14 @@ private fun HomeScreenLayout(
     homeScreenContract: HomeScreenContract
 ) {
     Box(
-        modifier = Modifier.fillMaxSize().navBarBottomPadding()
+        modifier = Modifier
+            .fillMaxSize()
+            .navBarBottomPadding()
     ) {
         BackgroundGradient(
-            modifier = Modifier.align(Alignment.TopStart).zIndex(1f)
+            modifier = Modifier
+                .align(Alignment.TopStart)
+                .zIndex(1f)
         )
 
         Column(modifier = Modifier.fillMaxSize()) {

presentation/src/main/java/com/london/presentation/feature/list/bottomsheets/DeleteListBottomSheet.kt

@@ -104,8 +104,7 @@ private fun Content(
                         shape = RoundedCornerShape(8.dp)
                     )
                     .background(color = NovixTheme.colors.iconBackgroundLow)
-                    .clickable(onClick = hideSheet)
-                ,
+                    .clickable(onClick = hideSheet),
                 contentAlignment = Alignment.Center
             ) {
                 Icon(

presentation/src/main/java/com/london/presentation/feature/reviews/ReviewsScreen.kt

@@ -90,9 +90,11 @@ private fun Content(
 
     Box(
         modifier = Modifier.fillMaxSize()
-    ){
+    ) {
         BackgroundGradient(
-            modifier = Modifier.align(Alignment.TopStart).zIndex(1f)
+            modifier = Modifier
+                .align(Alignment.TopStart)
+                .zIndex(1f)
         )
 
         Column(

presentation/src/main/java/com/london/presentation/feature/welcome/onboarding/OnboardingEffect.kt

@@ -1,6 +1,6 @@
 package com.london.presentation.feature.welcome.onboarding
 
 sealed interface OnboardingEffect {
-    data object NavigateToWelcome : OnboardingEffect
+    data object WelcomeNavigation : OnboardingEffect
     data class ScrollToPage(val page: Int) : OnboardingEffect
 }

presentation/src/main/java/com/london/presentation/feature/welcome/onboarding/OnboardingScreen.kt

@@ -50,6 +50,7 @@ import com.london.designsystem.theme.NovixTheme
 import com.london.designsystem.theme.ThemePreviews
 import com.london.designsystem.utils.painter
 import com.london.presentation.R
+import com.london.presentation.utils.Listen
 import kotlinx.coroutines.CoroutineScope
 
 @Composable
@@ -66,7 +67,19 @@ fun OnboardingScreen(
     )
 
     HandlePagerStateChanges(pagerState, viewModel)
-    HandleEffects(effect, viewModel, pagerState, scope, onComplete)
+
+    effect?.Listen { currentEffect ->
+        when (currentEffect) {
+            is OnboardingEffect.ScrollToPage -> {
+                viewModel.scrollToPage(pagerState, currentEffect.page, scope)
+            }
+
+            OnboardingEffect.WelcomeNavigation -> {
+                viewModel.onboardingFinished()
+                onComplete()
+            }
+        }
+    }
 
     Box(
         modifier = Modifier
@@ -87,30 +100,6 @@ fun OnboardingScreen(
     }
 }
 
-@Composable
-private fun HandleEffects(
-    effect: OnboardingEffect?,
-    viewModel: OnboardingViewModel,
-    pagerState: PagerState,
-    scope: CoroutineScope,
-    onComplete: () -> Unit
-) {
-    LaunchedEffect(effect) {
-        when (effect) {
-            is OnboardingEffect.ScrollToPage -> {
-                viewModel.scrollToPage(pagerState, effect.page, scope)
-            }
-
-            OnboardingEffect.NavigateToWelcome -> {
-                viewModel.onboardingFinished()
-                onComplete()
-            }
-
-            null -> {}
-        }
-    }
-}
-
 @Composable
 private fun Content(
     pagerState: PagerState,

presentation/src/main/java/com/london/presentation/feature/welcome/onboarding/OnboardingViewModel.kt

@@ -1,16 +1,14 @@
 package com.london.presentation.feature.welcome.onboarding
 
-import android.util.Log
 import androidx.compose.animation.core.FastOutSlowInEasing
 import androidx.compose.animation.core.tween
 import androidx.compose.foundation.pager.PagerState
-import androidx.lifecycle.viewModelScope
 import com.london.domain.service.AppPreferencesService
 import com.london.presentation.shared.base.BaseViewModel
 import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
+import timber.log.Timber
 import javax.inject.Inject
 
 @HiltViewModel
@@ -51,19 +49,24 @@ class OnboardingViewModel @Inject constructor(
 
     fun navigateToWelcome() {
         setOnBoardingShown()
-        emitEffect(OnboardingEffect.NavigateToWelcome)
+        emitEffect(OnboardingEffect.WelcomeNavigation)
     }
 
     fun onboardingFinished() {
-        viewModelScope.launch(Dispatchers.IO) {
-            runCatching { appPreferencesService.setOnBoardingShown() }
-                .onFailure { Log.e("OnboardingViewModel", "onboardingFinished: ", it) }
-        }
+        tryToExecute(
+            block = { appPreferencesService.setOnBoardingShown() },
+            onError = { errorState ->
+                Timber.e("Failed to set onboarding shown: $errorState")
+            }
+        )
     }
 
     private fun setOnBoardingShown() {
-        viewModelScope.launch(Dispatchers.IO) {
-            runCatching { appPreferencesService.setOnBoardingShown() }
-        }
+        tryToExecute(
+            block = { appPreferencesService.setOnBoardingShown() },
+            onError = { errorState ->
+                Timber.e("Failed to set onboarding shown: $errorState")
+            }
+        )
     }
 }

presentation/src/main/java/com/london/presentation/feature/welcome/onboarding/WelcomeScreen.kt

@@ -38,7 +38,7 @@ import com.london.presentation.R
 @Composable
 fun WelcomeScreen(
     onNavigateLogin: () -> Unit,
-    onNavigateContinue: () -> Unit,
+    onNavigateAsGuest: () -> Unit,
 ) {
 
     val screenHeight = with(LocalDensity.current) {
@@ -62,14 +62,14 @@ fun WelcomeScreen(
     }
     Content(
         onNavigateLogin = onNavigateLogin,
-        onNavigateContinue = onNavigateContinue
+        onNavigateAsGuest = onNavigateAsGuest
     )
 }
 
 @Composable
 private fun Content(
     onNavigateLogin: () -> Unit,
-    onNavigateContinue: () -> Unit,
+    onNavigateAsGuest: () -> Unit,
     modifier: Modifier = Modifier
 ) {
     Column(
@@ -118,7 +118,7 @@ private fun Content(
 
         OutlineButton(
             text = stringResource(R.string.continue_as_guest),
-            onClick = onNavigateContinue,
+            onClick = onNavigateAsGuest,
             modifier = Modifier.fillMaxWidth(),
             hasLabel = true,
             icon = null,
@@ -171,7 +171,7 @@ private fun WelcomePoster(modifier: Modifier = Modifier) {
 @Composable
 private fun PreviewWelcomeScreen() {
     WelcomeScreen(
-        onNavigateContinue = {},
+        onNavigateAsGuest = {},
         onNavigateLogin = {}
     )
 }

presentation/src/main/java/com/london/presentation/shared/buildscreen/BuildScreen.kt

@@ -83,7 +83,6 @@ fun BuildScreen(
         }
 
 
-
         (pagingFlow != null) &&
             pagingFlow.isEmpty() &&
             emptyLayoutMessage.isNotNull() -> {