Add tasks for networking solutions - #27
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single text line in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
networking/README.md (1)
39-44: Docker Networking resource has no corresponding task.The Docker Networking link is unrelated to any of the four defined tasks, which may confuse participants about the week's scope. Consider either removing it or adding a Docker networking task (e.g., exploring bridge/host/overlay networks).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@networking/README.md` around lines 39 - 44, The "Docker Networking" link in the "Resources to Get Started" section is not tied to any task; either remove that link or add a matching task entry—for example, add a short task named "Docker networking" (e.g., explore bridge/host/overlay networks and create a container network demo) and reference the Docker docs; update the README's task list to include this new task title so participants have a clear action tied to the "Docker Networking" resource.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@networking/README.md`:
- Around line 50-60: The example submission under "Example Submission Post"
contains the bullet "✅ Set up my first web server" which doesn't map to any
defined task; update the example to reference an existing task instead (e.g.,
replace that bullet with "✅ Created a cheat sheet for networking commands" or
another task from the Tasks section), or alternatively add a new task in the
Tasks list that explicitly covers setting up a web server so the example aligns
with the documented tasks.
- Around line 50-60: The Example Submission Post block in the README currently
places bare hashtags that are parsed as ATX headings (MD018); edit the Example
Submission Post section and wrap the entire sample post text (the quoted
multi-line sample starting with "Week 1 of `#90DaysOfDevOps2025` completed! 🚀"
and ending with "#Networking `#DevOps` `#90DaysOfDevOps`") in either a fenced code
block (``` ... ```) or a blockquote (> on each line) so the hashtags are treated
as content rather than headings.
---
Nitpick comments:
In `@networking/README.md`:
- Around line 39-44: The "Docker Networking" link in the "Resources to Get
Started" section is not tied to any task; either remove that link or add a
matching task entry—for example, add a short task named "Docker networking"
(e.g., explore bridge/host/overlay networks and create a container network demo)
and reference the Docker docs; update the README's task list to include this new
task title so participants have a clear action tied to the "Docker Networking"
resource.
| ### Example Submission Post: | ||
| "Week 1 of #90DaysOfDevOps2025 completed! 🚀 | ||
|
|
||
| ✅ Learned OSI & TCP/IP models | ||
| ✅ Explored AWS Security Groups | ||
| ✅ Practiced networking commands | ||
| ✅ Set up my first web server | ||
|
|
||
| Check out my blog here: [Your Blog/GitHub Link] | ||
|
|
||
| #Networking #DevOps #90DaysOfDevOps" |
There was a problem hiding this comment.
Example submission references a task not defined in the document.
Line 56 — ✅ Set up my first web server — does not correspond to any of the four defined tasks (OSI/TCP-IP models, protocols & ports, AWS EC2 + security groups, networking commands). Either add a matching task in the Tasks section or replace this bullet with one that maps to an existing task (e.g., ✅ Created a cheat sheet for networking commands).
✏️ Proposed fix
-✅ Set up my first web server
+✅ Created a networking commands cheat sheet📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### Example Submission Post: | |
| "Week 1 of #90DaysOfDevOps2025 completed! 🚀 | |
| ✅ Learned OSI & TCP/IP models | |
| ✅ Explored AWS Security Groups | |
| ✅ Practiced networking commands | |
| ✅ Set up my first web server | |
| Check out my blog here: [Your Blog/GitHub Link] | |
| #Networking #DevOps #90DaysOfDevOps" | |
| ### Example Submission Post: | |
| "Week 1 of `#90DaysOfDevOps2025` completed! 🚀 | |
| ✅ Learned OSI & TCP/IP models | |
| ✅ Explored AWS Security Groups | |
| ✅ Practiced networking commands | |
| ✅ Created a networking commands cheat sheet | |
| Check out my blog here: [Your Blog/GitHub Link] | |
| `#Networking` `#DevOps` `#90DaysOfDevOps`" |
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 60-60: No space after hash on atx style heading
(MD018, no-missing-space-atx)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@networking/README.md` around lines 50 - 60, The example submission under
"Example Submission Post" contains the bullet "✅ Set up my first web server"
which doesn't map to any defined task; update the example to reference an
existing task instead (e.g., replace that bullet with "✅ Created a cheat sheet
for networking commands" or another task from the Tasks section), or
alternatively add a new task in the Tasks list that explicitly covers setting up
a web server so the example aligns with the documented tasks.
Markdown lint error MD018: social-media hashtags misread as ATX headings.
The bare #Networking #DevOps #90DaysOfDevOps`` on Line 60 triggers MD018 (no space after `#` in ATX-style heading). Wrapping the entire example post in a fenced code block or blockquote prevents this misinterpretation and also makes it visually clearer that it's a sample post.
✏️ Proposed fix — wrap in a blockquote
-### Example Submission Post:
-"Week 1 of `#90DaysOfDevOps2025` completed! 🚀
-
-✅ Learned OSI & TCP/IP models
-✅ Explored AWS Security Groups
-✅ Practiced networking commands
-✅ Set up my first web server
-
-Check out my blog here: [Your Blog/GitHub Link]
-
-#Networking `#DevOps` `#90DaysOfDevOps`"
+### Example Submission Post
+
+> Week 1 of `#90DaysOfDevOps2025` completed! 🚀
+>
+> ✅ Learned OSI & TCP/IP models
+> ✅ Explored AWS Security Groups
+> ✅ Practiced networking commands
+> ✅ Created a networking commands cheat sheet
+>
+> Check out my blog here: [Your Blog/GitHub Link]
+>
+> \#Networking \#DevOps \#90DaysOfDevOps📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### Example Submission Post: | |
| "Week 1 of #90DaysOfDevOps2025 completed! 🚀 | |
| ✅ Learned OSI & TCP/IP models | |
| ✅ Explored AWS Security Groups | |
| ✅ Practiced networking commands | |
| ✅ Set up my first web server | |
| Check out my blog here: [Your Blog/GitHub Link] | |
| #Networking #DevOps #90DaysOfDevOps" | |
| ### Example Submission Post | |
| > Week 1 of `#90DaysOfDevOps2025` completed! 🚀 | |
| > | |
| > ✅ Learned OSI & TCP/IP models | |
| > ✅ Explored AWS Security Groups | |
| > ✅ Practiced networking commands | |
| > ✅ Created a networking commands cheat sheet | |
| > | |
| > Check out my blog here: [Your Blog/GitHub Link] | |
| > | |
| > \#Networking \#DevOps \#90DaysOfDevOps |
🧰 Tools
🪛 markdownlint-cli2 (0.21.0)
[warning] 60-60: No space after hash on atx style heading
(MD018, no-missing-space-atx)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@networking/README.md` around lines 50 - 60, The Example Submission Post block
in the README currently places bare hashtags that are parsed as ATX headings
(MD018); edit the Example Submission Post section and wrap the entire sample
post text (the quoted multi-line sample starting with "Week 1 of
`#90DaysOfDevOps2025` completed! 🚀" and ending with "#Networking `#DevOps`
`#90DaysOfDevOps`") in either a fenced code block (``` ... ```) or a blockquote (>
on each line) so the hashtags are treated as content rather than headings.
|
ok |
1 participant
Summary by CodeRabbit