Week1 Networking Solution Done - #25
Open
Harshrajput30 wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughThese changes expand the 2025 DevOps curriculum by introducing structured networking educational material covering OSI/TCP/IP models, protocols, Azure NSG configuration, and networking commands, alongside a minor README formatting adjustment. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@2025/networking/Solution.txt`:
- Line 8: Replace the incorrect phrase "OPEN SYSTEM INTERCOMMUNICATION MODEL"
in the file (the OSI model heading) with the correct wording "OPEN SYSTEM
INTERCONNECTION MODEL" — locate the line containing "OSI MODEL - OPEN SYSTEM
INTERCOMMUNICATION MODEL" and change "Intercommunication" to "Interconnection"
(and normalize the double space to a single space).
- Around line 27-40: Normalize the quotation marks in the TCP description line
and remove the stray trailing quote: replace the smart quotes around the
sentence “Before sending data, TCP establishes a connection using a 3-way
handshake. It is used in applications like HTTP, HTTPS, FTP, and email.” with
straight ASCII quotes and delete the extra trailing double-quote at the end, and
ensure the subsequent 3-Way Handshake explanation uses consistent straight
quotes as well.
|
|
||
| 1. Understand OSI & TCP/IP Models | ||
|
|
||
| OSI MODEL - OPEN SYSTEM INTERCOMMUNICATION MODEL |
There was a problem hiding this comment.
Fix OSI model name typo.
“Intercommunication” should be “Interconnection.”
✏️ Proposed fix
-OSI MODEL - OPEN SYSTEM INTERCOMMUNICATION MODEL
+OSI MODEL - OPEN SYSTEM INTERCONNECTION MODEL📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| OSI MODEL - OPEN SYSTEM INTERCOMMUNICATION MODEL | |
| OSI MODEL - OPEN SYSTEM INTERCONNECTION MODEL |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@2025/networking/Solution.txt` at line 8, Replace the incorrect phrase "OPEN
SYSTEM INTERCOMMUNICATION MODEL" in the file (the OSI model heading) with the
correct wording "OPEN SYSTEM INTERCONNECTION MODEL" — locate the line containing
"OSI MODEL - OPEN SYSTEM INTERCOMMUNICATION MODEL" and change
"Intercommunication" to "Interconnection" (and normalize the double space to a
single space).
Comment on lines
+27
to
+40
| Before sending data, TCP establishes a connection using a 3-way handshake. It is used in applications like HTTP, HTTPS, FTP, and email.” | ||
|
|
||
| Explain 3-Way Handshake (Very commonly asked) | ||
|
|
||
| You can say this: | ||
|
|
||
| “TCP uses a 3-way handshake to establish connection: | ||
|
|
||
| SYN – Client sends request to server | ||
|
|
||
| SYN-ACK – Server responds with acknowledgement | ||
|
|
||
| ACK – Client sends final acknowledgement and connection is established” | ||
|
|
There was a problem hiding this comment.
Normalize quotation marks and remove the stray trailing quote.
There’s a smart-quote mismatch and a trailing quote at the end of the TCP line that can confuse readers.
✏️ Proposed fix
-It ensures data is delivered accurately, in order, and without loss using mechanisms like acknowledgements, sequence numbers, and error checking.
-Before sending data, TCP establishes a connection using a 3-way handshake. It is used in applications like HTTP, HTTPS, FTP, and email.”
+It ensures data is delivered accurately, in order, and without loss using mechanisms like acknowledgements, sequence numbers, and error checking.
+Before sending data, TCP establishes a connection using a 3-way handshake. It is used in applications like HTTP, HTTPS, FTP, and email.
@@
-“TCP uses a 3-way handshake to establish connection:
+“TCP uses a 3-way handshake to establish connection:
@@
-ACK – Client sends final acknowledgement and connection is established”
+ACK – Client sends final acknowledgement and connection is established”🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@2025/networking/Solution.txt` around lines 27 - 40, Normalize the quotation
marks in the TCP description line and remove the stray trailing quote: replace
the smart quotes around the sentence “Before sending data, TCP establishes a
connection using a 3-way handshake. It is used in applications like HTTP, HTTPS,
FTP, and email.” with straight ASCII quotes and delete the extra trailing
double-quote at the end, and ensure the subsequent 3-Way Handshake explanation
uses consistent straight quotes as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit