fix(engine): 修正翻页到仓库底部时的跳过行数计算逻辑 - #207
Merged
Merged
Conversation
修正 188073f 遗留的过时注释 同步更新 _calculate_skip_rows 的 docstring 与行内注释 同时把 _progressive_drag 中日志精度从 .1f 统一为.3f 与 _calculate_skip_rows 的日志格式一致。
修复 _execute_grid_scan 中两处无保护的 icon_y_list[1] 索引
Contributor
|
已合并,感谢 PR 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[x] 我已经阅读并理解了项目的贡献指南(CONTRIBUTING.md)。
提交类型(必填)
请确认本 PR 符合以下任意一项:
🎨 代码风格与质量保证
x,y,i等)。pre-commit检查。📝 修改描述
我发现仓库滚动到底部时计算具体滚动行数容易出错(#204),发现出错主要由以下2个原因构成:
现在修改如下:
另外,我新增(vibe)了一个脚本
scripts\test_inventory_page_flip.py,可以在不进行锁定/解锁的情况下进行识别并滚动翻页,使用方式详见其注释。🧪 验证与测试结果
受限于本地条件,我只能测试1920*1080分辨率下可以正常运行,对应基质行高155px,仓库页面高度约820px。
我也只能测试仓库中包含6行基质的情况,暂时没有理智刷出来更多基质 :(
日志节选:
仓库截图可见于原Issue。
Sourcery 总结
修正仓库末页翻页的行数计算,并新增不修改基质状态的翻页识别测试工具。
修复当仓库翻至末页时的行数计算,并新增一个不会修改基质状态的翻页识别测试工具。
新功能:
缺陷修复:
Original summary in English
Summary by Sourcery
修正仓库末页翻页的行数计算,并新增不修改基质状态的翻页识别测试工具。
New Features:
Bug Fixes: