fix(elasticsearch): refresh the index on bulkCreate like single-item writes - #42
Merged
Merged
Conversation
…writes createItem() and updateItem() request refresh=true so written documents are immediately searchable, but bulkCreate() did not. Current data trackers written by the populate command were therefore invisible to the tracker lookup until Elasticsearch refreshed on its own, and update logs arriving in that window were silently dropped because the handler found no tracker to compare against.
…efresh # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ElasticsearchService::createItem()andupdateItem()requestrefresh=true, so written documents are immediately searchable, and the update flow relies on that (create -> immediate update reads the tracker back).bulkCreate()does not refresh, so current data trackers written bylocastic:activity-logs:populate-current-data-trackersare invisible to the tracker lookup until Elasticsearch refreshes on its own (default 1s). Update logs arriving in that window are silently dropped: the handler finds no tracker and returns early, meaning the very first change after repopulating trackers can go unlogged.Found running a backend-parity harness against a demo app: a populate-then-update sequence logged the change on a relational storage adapter but dropped it on Elasticsearch.
Changes
bulkCreate()sendsrefresh: 'true', consistent with the other write methods. Populate runs in batches of 250 per message, so one refresh per batch is a negligible cost for an occasional admin operationVerification