Skip to content

Replace component reconciliation with a projectional core #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
merryman wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace component reconciliation with a projectional core #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
858ccbb
🫓👼🧰📙🎨📇: replace component reconciliation with projectional core
merryman Jul 20, 2026
e07bbf7
🧰🧩🎨👔: harden reconciliation fuzz coverage and integration
merryman Jul 26, 2026
1a7f3b1
🧰🧩🎨👔: expand reconciliation fuzz coverage and fix edge cases
merryman Jul 26, 2026
ad68cea
🧰🧩🎨👔: strengthen reconciliation fuzz oracle
merryman Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion flatn/flatn-cjs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9216,7 +9216,8 @@ function print (object, quote = '\"') {
if (object && Array.isArray(object)) { return '[' + object.map(print) + ']'; }
if (typeof object !== 'string') { return String(object); }
let result = String(object);
result = result.replace(/\n/g, '\\n\\\n');
result = result.replace(/\\/g, '\\\\');
result = result.replace(/\n/g, '\\n');
result = result.replace(/(")/g, '\\$1');
result = result.replace(/(')/g, '\\$1');
result = quote + result + quote;
Expand Down
6 changes: 3 additions & 3 deletions lively.halos/morph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,8 @@ class NameHolder extends Morph {
this.validName = !owner || !owner.getSubmorphNamed(newName) || oldName === newName;
if (this.target.isComponent && !evt.hasArrowPressed) {
// also confirm we are not in conflict with other stuff in the module scope
System.import('lively.ide/components/reconciliation.js').then(({ canBeRenamed }) => {
this.validName = this.validName && canBeRenamed(moduleManager.module(this.target[Symbol.for('lively-module-meta')].moduleId), oldName, newName);
System.import('lively.ide/components/component-definition.js').then(({ canBeRenamed }) => {
this.validName = this.validName && canBeRenamed(moduleManager.module(this.target[Symbol.for('lively-module-meta')].moduleId), newName);
signal(this, 'valid', [this.validName, newName]);
});
return;
Expand Down Expand Up @@ -1193,7 +1193,7 @@ class ComponentHaloItem extends RoundHaloItem {
const {
insertComponentDefinition,
removeComponentDefinition
} = await System.import('lively.ide/components/reconciliation.js');
} = await System.import('lively.ide/components/component-definition.js');
const { InteractiveComponentDescriptor } = await System.import('lively.ide/components/editor.js');
const Browser = await System.import('lively.ide/js/browser/ui.cp.js');
if (toBeComponent) {
Expand Down
Loading
Loading