Fix daily docs coverage dependency conflict - #1809
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Pin
@babel/eslint-parserto version 7.29.7 in the daily docs-coverage job.Why
The workflow pins ESLint 8 but installed the Babel ESLint parser without a version constraint. Since Babel parser 8 became the default release, npm resolves it with an ESLint 9/10 peer requirement and aborts with
ERESOLVEbefore documentation linting starts.This dependency conflict has made every scheduled daily run fail since June 17 even when the test job succeeds. The missing docs artifact also causes the downstream summary job to fail.
Impact
The docs-coverage job can install its tooling and run again without migrating the repository's legacy ESLint configuration to ESLint 9.
Validation
main@babel/eslint-parser@7.29.7,eslint@8.57.0, andeslint-plugin-jsdocinstall without peer conflictsnpx eslint -c .eslintrc.js lively.*/*.js | grep '✖'successfullygit diff --check