Add Detailed Timer IconDisplayMode#942
Draft
CryZe wants to merge 1 commit into
Draft
Conversation
The Detailed Timer currently makes its segment icon span the full component, which also shifts comparison rows to the right. Add `IconDisplayMode` with `Hidden`, `BothRows`, and `FirstRow` so layouts can keep the segment name aligned with the icon while allowing comparisons to use the full width. Keep the serialized setting name `display_icon` and deserialize its released boolean representation as `Hidden` or `BothRows`. Expose the typed value through settings metadata and the C API, update localized descriptions, and preserve LiveSplit XML compatibility. Update the renderer and state bindings for the new mode, and cover the serialization migration and first-row rendering behavior. This implements [#660](#660).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Detailed Timer currently makes its segment icon span the full component, which also shifts comparison rows to the right. Add
IconDisplayModewithHidden,BothRows, andFirstRowso layouts can keep the segment name aligned with the icon while allowing comparisons to use the full width.Keep the serialized setting name
display_iconand deserialize its released boolean representation asHiddenorBothRows. Expose the typed value through settings metadata and the C API, update localized descriptions, and preserve LiveSplit XML compatibility.Update the renderer and state bindings for the new mode, and cover the serialization migration and first-row rendering behavior. This implements LiveSplit/livesplit-core#660.