Skip to content

Parse OpenSplit Metadata#940

Merged
CryZe merged 1 commit into
LiveSplit:masterfrom
CryZe:opensplit-metadata
Jul 22, 2026
Merged

Parse OpenSplit Metadata#940
CryZe merged 1 commit into
LiveSplit:masterfrom
CryZe:opensplit-metadata

Conversation

@CryZe

@CryZe CryZe commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • parse OpenSplit platform and speedrun.com variables into run metadata
  • store an available real-time world record as the permanent World Record custom variable, matching the existing LibreSplit convention
  • keep format-specific OpenSplit coverage beside the parser while reserving run-file fixtures for integration tests
  • remove redundant formatting borrows across the C API binding generator

Why

OpenSplit now stores speedrun.com metadata that livesplit-core already has representations for, but the OpenSplit parser previously ignored the variables and cached world record. This preserves that information when importing OpenSplit files.

Validation

  • cargo fmt --all -- --check
  • cargo clippy --offline --manifest-path capi/bind_gen/Cargo.toml --all-targets -- -D warnings
  • cargo test --offline --lib run::parser::opensplit::tests
  • cargo test --offline --test split_parsing

Parse OpenSplit platform, speedrun.com variables, and world record information into run metadata. Store available world record times using the existing permanent custom variable convention and keep format-specific coverage alongside the parser.

Also remove redundant formatting borrows throughout the C API binding generator so it passes current Clippy with warnings denied.
@CryZe CryZe added this to the v0.14 milestone Jul 22, 2026
@CryZe CryZe added c api The issue or pull request is about the C API. parsing This is about one of the parsers. bindings This is about the bindings / binding generator. rust Pull requests that update Rust code labels Jul 22, 2026
@CryZe
CryZe enabled auto-merge (squash) July 22, 2026 19:05
@CryZe
CryZe merged commit d896beb into LiveSplit:master Jul 22, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bindings This is about the bindings / binding generator. c api The issue or pull request is about the C API. parsing This is about one of the parsers. rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant