Improve Segment Group Selection and Gap Separators#939
Merged
CryZe merged 2 commits intoJul 22, 2026
Conversation
Add backend-owned toggle and range-selection operations for complete segment groups and expose them through the C API. This lets every frontend implement standard modifier selection without reconstructing group ranges or duplicating the editor's non-empty-selection invariant.
Rename the last-split-specific setting to show_gap_separators and apply it to every pronounced separator caused by omitted rows. Preserve existing JSON layouts through a Serde alias and continue accepting LiveSplit's historical XML tag while exposing the accurate name through settings metadata, localizations, and API bindings.
CryZe
added
enhancement
CryZe
marked this pull request as ready for review
July 22, 2026 16:58
CryZe
enabled auto-merge
July 22, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show_gap_separatorsand apply it to every pronounced separator caused by omitted rowsWhy
Segment-group selection rules belong in livesplit-core so web, desktop, and other frontends do not need to reconstruct group ranges or duplicate the Run Editor's non-empty-selection invariant.
The separator setting previously referred only to the last displayed split, even though pronounced separators now identify gaps after group headers as well. The generalized name and behavior accurately cover both cases.
Validation
cargo fmt --checkcargo clippy --workspace --all-targets --all-featurescargo test --workspace