Fix and improve hub challenges - #961
Merged
Merged
Conversation
…nts, properly log fails
jvyden
reviewed
Oct 16, 2025
Member
|
pls click 'resolve conversation' when fixing things |
Contributor
Author
Ok I will do that from now on. I've done this rarely until now because i wasn't always sure you're 100% ok with my changes |
Member
|
If I have an issue with how it was resolved, it's fine, I'll bring it up in the next round of reviews - but I try not to waste my/your time by reviewing code that's actively being worked on. I usually wait for comments to be resolved first before doing so. You can also hit 're-request review' in the top right to make it infinitely more clear. |
Contributor
Author
I completely forgot about that |
jvyden
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes challenge DB methods to work under EF and Postgres, optimizes them and the challenge game endpoints, gets rid of challenge expiration as that is counter-productive, and reworks many of my comments and summaries. Also adds more slot types to
GameSlotTypeandRoomSlotTypein the process.