Don't try to block commands while uploading a level - #940
Merged
Conversation
jvyden
approved these changes
Aug 28, 2025
jvyden
left a comment
Member
There was a problem hiding this comment.
Yeah this system never really worked.
This was done for security reasons (theoretically commands could be injected as you're publishing a copied level) but it's fine as we explicitly do not do trusted operations in filtering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of the mechanism which uses
CommandServiceto block commands while publishing a level.We can't catch all cases of
/filterrequests which are not chat messages (e.g. LBP3 sends the level strings to filter before its/startPublishrequest, and LBP2 can also send level strings during create mode).More importantly, if the game successfully does a
/startPublishrequest, but its/publishrequest fails in any way or the user tries to update a level instead of publishing a new one, their commands would continue to silently get blocked, which has already caused confusion (see #937).The latter issue could be fixed and worked around by making some changes to the
/publishendpoint method and theCommandService, but since we also can't tell whether a/filterrequest does actually contain a chat message or something else half the time, making the mechanism not very effective to begin with, I think it makes more sense to just get rid of it entirely.Closes #937.