Skip to content

Don't try to block commands while uploading a level - #940

Merged
jvyden merged 1 commit into
LittleBigRefresh:mainfrom
Toastbrot236:commandfix
Aug 28, 2025
Merged

Don't try to block commands while uploading a level#940
jvyden merged 1 commit into
LittleBigRefresh:mainfrom
Toastbrot236:commandfix

Conversation

@Toastbrot236

Copy link
Copy Markdown
Contributor

This gets rid of the mechanism which uses CommandService to block commands while publishing a level.

We can't catch all cases of /filter requests which are not chat messages (e.g. LBP3 sends the level strings to filter before its /startPublish request, and LBP2 can also send level strings during create mode).
More importantly, if the game successfully does a /startPublish request, but its /publish request fails in any way or the user tries to update a level instead of publishing a new one, their commands would continue to silently get blocked, which has already caused confusion (see #937).

The latter issue could be fixed and worked around by making some changes to the /publish endpoint method and the CommandService, but since we also can't tell whether a /filter request does actually contain a chat message or something else half the time, making the mechanism not very effective to begin with, I think it makes more sense to just get rid of it entirely.

Closes #937.

@jvyden jvyden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this system never really worked.

This was done for security reasons (theoretically commands could be injected as you're publishing a copied level) but it's fine as we explicitly do not do trusted operations in filtering.

@jvyden
jvyden merged commit db5af41 into LittleBigRefresh:main Aug 28, 2025
3 checks passed
@Toastbrot236
Toastbrot236 deleted the commandfix branch August 29, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commands don't work for certain people.

2 participants