Improve result filter initialization, add new filters - #926
Merged
jvyden merged 11 commits intoAug 28, 2025
Conversation
…t LBP2 Move and LBP3 filters
jvyden
self-requested a review
August 23, 2025 22:05
jvyden
reviewed
Aug 23, 2025
jvyden
left a comment
jvyden
left a comment
Member
There was a problem hiding this comment.
Looks okay, but:
- This needs a rebase. I can do this if you'd like.
- Please don't do this kind of mass renaming to a core type in the middle of the PR. it made things very hard to follow. if it must be done, it should be in a new PR.
Contributor
Author
|
Ok, go ahead with the rebase. Also, on the one file I renamed: VS Code has properly shown what exactly was changed in the file (even with the rename), but looks like Github doesn't. |
Contributor
Author
|
I'm doing the rebase right now |
Contributor
Author
|
Merging like this ended up being easier. Also, now that I've reverted the rename, I hope this PR is easier to follow now. |
jvyden
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames
LevelFilterSettingstoResultFilterSettings, adds new filters to that class and implements most of them (those being lbp3-exclusive filters like adventure filtering and the result types to filter, which is why I renamed the class, aswell as filtering levels which require move controllers), and splits the constructor into static initialization classes, one for API requests and one for game requests. The new filters I added currently only work for game requests, not for API requests, to not make this PR too long.