grief reports implementation - #886
Conversation
|
i still have to rewrite tests but review whats made so far |
remove comment Co-authored-by: jvyden <jvyden@jvyden.xyz> Signed-off-by: Nya0 <59615141+Nya0@users.noreply.github.com>
i need to make a db migration for the additions |
…ion' into feature/grief-report-implementation
|
what are your thoughts on more validation for reporting existing levels? checking if initialstatehash matches level hash or checking that the player played the level? or in general that other players specified were actually in that session? in it's current state it's not the safest |
|
We can flag these scenarios, but we shouldn't outright deny reports. Should be a separate addition, I think it can go in as-is. |
|
Also to be clear I won't be doing another round of review until tests are fixed and this is un-drafted |
|
Are there any other features in mind before i write tests |
|
API access would be nice but can come separately as this is a big enough PR |
|
its done, ready for undrafting |
2 participants
closes #853