Skip to content

Completely remove CacheService due to unmaintainability #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Toastbrot236 merged 2 commits into from
Aug 27, 2026
Merged

Completely remove CacheService due to unmaintainability #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60fc0f5
Remove CacheService due to unmaintainability
Toastbrot236 Aug 27, 2026
da616ec
Don't use dequeued postgres container if it is null
Toastbrot236 Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Refresh.Core/Extensions/GameAssetExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ private static string TransformImage(this GameAsset asset, TokenGame game, IData
hash =>
{
dataContext.Database.SetMainlinePhotoHash(asset, hash);
dataContext.Cache.CacheAsset(asset.AssetHash, asset);
},
() => throw new NotSupportedException(),
_ => throw new NotSupportedException()
Expand All @@ -179,13 +178,11 @@ private static string TransformImage(this GameAsset asset, TokenGame game, IData
hash =>
{
dataContext.Database.SetMainlineIconHash(asset, hash);
dataContext.Cache.CacheAsset(asset.AssetHash, asset);
},
() => asset.AsMipIconHash,
hash =>
{
dataContext.Database.SetMipIconHash(asset, hash);
dataContext.Cache.CacheAsset(asset.AssetHash, asset);
}
);
}
Expand Down
2 changes: 1 addition & 1 deletion Refresh.Core/Helpers/ResourceValidationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public static ValidatedAssetResult ValidateReference(AssetValidationParameters p
return new(NotFound, null, $"The used {assetTypeStr} did not exist on the server.");
}

asset = parameters.Cache.GetAssetInfo(parameters.AssetRef, parameters.Database);
asset = parameters.Database.GetAssetFromHash(parameters.AssetRef);

// Only try to import if the asset exists in the data store
if (existsInDataStore && asset == null)
Expand Down
Loading
Loading