feat: restore web3js exports#382
Conversation
d060cff to
b19ecb0
Compare
|
Hi there, thanks for the PR. There are a quite few implementation details that can be improved here (e.g. no need for
My recommendation, if supporting web3.js is desired moving forward, would be to create a new package such as |
Separate tsconfig files were added for explicit CJS-ESM handling when building.
That's fair, do you think the web3js package should be added as a sibling to |
|
IIRC, the way this package is created and published is pretty complex as it bundles various binaries. Having it in a separate repo would duplicate a lot of the CI work in this repo unfortunately so I'd see it more as a sibling. A cleaner alternative (which would be a much bigger refactoring though so likely out-of-scope) would be to only publish the generated internal LiteSVM class from this repo as something like |
|
@lorisleiva shall I open a separate new PR for the changes? it's bigger in scope, and is no longer committed on top of the above commits |
web3js and Kit can be optionally imported through split exports